[llvm-bugs] [Bug 28380] New: incorrect logic when detect windows SDK

[via llvm-bugs]

https://llvm.org/bugs/show_bug.cgi?id=28380

            Bug ID: 28380
           Summary: incorrect logic when detect windows SDK
           Product: clang
           Version: trunk
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: normal
          Priority: P
         Component: Driver
          Assignee: unassignedclangbugs at nondot.org
          Reporter: comicfans44 at gmail.com
                CC: llvm-bugs at lists.llvm.org
    Classification: Unclassified

Created attachment 16669
  --> https://llvm.org/bugs/attachment.cgi?id=16669&action=edit
misc patch to address this

I've found clang version 

 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@274110
91177308-0d34-0410-b5e6-96231b3b80d8

counld not detect windows SDK, attached patch address this.

1. readFullStringValue returns bool, should not compared with ERROR_SUCCESS
2. RegQueryValueExW string may contain null terminating char ,should be trimmed
these leads getSystemRegistryString return incorrect result, and following
getWindows10SDKVersion gives incorrect result for string append, prevents
correct
SDK detected.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20160701/fe797cdf/attachment.html>