[LLVMbugs] [Bug 19044] New: TableGen.cmake concats dependencies without a seperator

[bugzilla-daemon at llvm.org]

http://llvm.org/bugs/show_bug.cgi?id=19044

            Bug ID: 19044
           Summary: TableGen.cmake concats dependencies without a
                    seperator
           Product: new-bugs
           Version: trunk
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: normal
          Priority: P
         Component: new bugs
          Assignee: unassignedbugs at nondot.org
          Reporter: yaron.keren at gmail.com
                CC: llvmbugs at cs.uiuc.edu
    Classification: Unclassified

In TableGen/cmake:54

  set(TABLEGEN_OUTPUT ${TABLEGEN_OUTPUT} ${CMAKE_CURRENT_BINARY_DIR}/${ofn}
PARENT_SCOPE)

If I print out TABLEGEN_OUTPUT values:

-- Targeting X86
{TABLEGEN_OUTPUT} =

{TABLEGEN_OUTPUT} = C:/llvm/msvc/lib/Target/X86/X86GenRegisterInfo.inc

{TABLEGEN_OUTPUT} =
C:/llvm/msvc/lib/Target/X86/X86GenRegisterInfo.incC:/llvm/msvc/lib/Target/X86/X86GenDisassemblerTables.inc

{TABLEGEN_OUTPUT} =
C:/llvm/msvc/lib/Target/X86/X86GenRegisterInfo.incC:/llvm/msvc/lib/Target/X86/X86GenDisassemblerTables.incC:/llvm/msvc/lib/Target/X86/X86GenInstrInfo.inc

{TABLEGEN_OUTPUT} =
C:/llvm/msvc/lib/Target/X86/X86GenRegisterInfo.incC:/llvm/msvc/lib/Target/X86/X86GenDisassemblerTables.incC:/llvm/msvc/lib/Target/X86/X86GenInstrInfo.incC:/llvm/msvc/lib/Target/X86/X86GenAsmWriter.inc

etc...

Simple string concatention makes no sense, some separator should be used?
Maybe a space like this:

  set(TABLEGEN_OUTPUT ${TABLEGEN_OUTPUT} ${CMAKE_CURRENT_BINARY_DIR}/${ofn} " "
PARENT_SCOPE)

I don't know. Similar problem is in line 70, 

  set(LLVM_COMMON_DEPENDS ${LLVM_COMMON_DEPENDS} ${target} PARENT_SCOPE)

again dependencies without separator.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20140304/d651bbea/attachment.html>