[LLVMbugs] [Bug 21762] New: Missing optimisation for bitmanipulation

[bugzilla-daemon at llvm.org]

http://llvm.org/bugs/show_bug.cgi?id=21762

            Bug ID: 21762
           Summary: Missing optimisation for bitmanipulation
           Product: new-bugs
           Version: 3.4
          Hardware: PC
                OS: All
            Status: NEW
          Severity: normal
          Priority: P
         Component: new bugs
          Assignee: unassignedbugs at nondot.org
          Reporter: Lars.Rasmusson at sics.se
                CC: llvmbugs at cs.uiuc.edu
    Classification: Unclassified

Submitting bug, as requested in
http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-December/079351.html



I'm compiling a large code base that uses tagged data, with the tag in the two
lowest bits.

I.e. ints are shifted two steps to the left and have 2 in the tag bits,
pointers have 0 in the tag bits, etc.

When I compile the code, I notice that there are places where -O3 doesn't
remove unnecessary tag bit tests and manipulations, when they are performed
with bitwise manipulation (which is how it is implemented in the large code
base I'm working with).

I've provided a small example below.

However, when I change from using 'and' and 'or' to using subtraction and
addition, llvm is able to detect and optimise the code correctly.



/***************************************************/

/*  The two LSB of x0 are 'tag bits'  */
/*  that we want to manipulate.       */
extern long x0;

void go_error(void) __attribute__ ((noreturn));

void example_not_optimized(void)
{
  if((x0 & 3) == 2) {
    // Here the tag bits are removed and added
    // with bitwise 'and' and 'or'.
    x0 = ((x0 & ~3) | 2) + 12;
  } else {
    go_error();
  }
}

/*
define void @example_not_optimized() #0 {
  %1 = load i64* @x0, align 8, !tbaa !1
  %2 = and i64 %1, 3
  %3 = icmp eq i64 %2, 2
  br i1 %3, label %4, label %8

; <label>:4                                       ; preds = %0
  %5 = and i64 %1, -4                ; this should be optimized away
  %6 = or i64 %5, 2                  ; this should be optimized away
  %7 = add nsw i64 %6, 12
  store i64 %7, i64* @x0, align 8, !tbaa !1
  ret void

; <label>:8                                       ; preds = %0
  tail call void @go_error() #2
  unreachable
}
*/


void example_optimized(void)
{
  if((x0 & 3) == 2) {
    // Here the tag bits are removed and added
    // with subtraction and addition.
    x0 = (x0 - (x0 & 3) + 2) + 12;
  } else {
    go_error();
  }
}

/*
define void @example_optimized() #0 {
  %1 = load i64* @x0, align 8, !tbaa !1
  %2 = and i64 %1, 3
  %3 = icmp eq i64 %2, 2
  br i1 %3, label %4, label %6

; <label>:4                                       ; preds = %0
  %5 = add i64 %1, 12                      ; Here it worked OK.
  store i64 %5, i64* @x0, align 8, !tbaa !1
  ret void

; <label>:6                                       ; preds = %0
  tail call void @go_error() #2
  unreachable
}

 */

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20141205/4e810b83/attachment.html>