[LLVMbugs] [Bug 14976] New: Lit malforms multiline RUN: line, eg. clang/test/Preprocessor/macro-multiline.c

[bugzilla-daemon at llvm.org]

http://llvm.org/bugs/show_bug.cgi?id=14976

             Bug #: 14976
           Summary: Lit malforms multiline RUN: line, eg.
                    clang/test/Preprocessor/macro-multiline.c
           Product: Test Suite
           Version: trunk
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P
         Component: lit
        AssignedTo: unassignedbugs at nondot.org
        ReportedBy: geek4civic at gmail.com
                CC: daniel at zuster.org, llvmbugs at cs.uiuc.edu
    Classification: Unclassified


Preprocessor/macro-multiline.c has been disabled since r169458.

// RUN: %clang -E %s "-DX=A
// RUN: THIS_SHOULD_NOT_EXIST_IN_THE_OUTPUT" > %t
// RUN: grep "GOOD: A" %t
// RUN: not grep THIS_SHOULD_NOT_EXIST_IN_THE_OUTPUT %t

With executeScript(), Output/macro-multiline.c.script is generated like below;

{ ${BUILD}/bin/./clang  -E ${SOURCE}/clang/test/Preprocessor/macro-multiline.c
"-DX=A; } &&
{ THIS_SHOULD_NOT_EXIST_IN_THE_OUTPUT" >
${BUILD}/tools/clang/test/Preprocessor/Output/macro-multiline.c.tmp; } &&
{ grep "GOOD: A"
${BUILD}/tools/clang/test/Preprocessor/Output/macro-multiline.c.tmp; } &&
{ not grep THIS_SHOULD_NOT_EXIST_IN_THE_OUTPUT
${BUILD}/tools/clang/test/Preprocessor/Output/macro-multiline.c.tmp; }

Although it runs apparently successfully, I don't think it is expected.

With executeTclScriptInternal(), on bash-less win32, it crashes.

FAIL: Clang :: Preprocessor/macro-multiline.c (1 of 1)
******************** TEST 'Clang :: Preprocessor/macro-multiline.c' FAILED
********************
shell parser error on: 'E:/path/to/build/bin/./clang.EXE  -E
e:\\path\\to\\clang\\test\\Preprocessor\\macro-multiline.c "-DX=A'
********************

Shall we fix this behavior, or should we let mutiline disallow?

-- 
Configure bugmail: http://llvm.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.