[LLVMbugs] [Bug 18314] New: std::cv_status should be a strongly type enum

[bugzilla-daemon at llvm.org]

http://llvm.org/bugs/show_bug.cgi?id=18314

            Bug ID: 18314
           Summary: std::cv_status should be a strongly type enum
           Product: libc++
           Version: unspecified
          Hardware: PC
                OS: All
            Status: NEW
          Severity: normal
          Priority: P
         Component: All Bugs
          Assignee: hhinnant at apple.com
          Reporter: andersca at icloud.com
                CC: llvmbugs at cs.uiuc.edu
    Classification: Unclassified

Created attachment 11777
  --> http://llvm.org/bugs/attachment.cgi?id=11777&action=edit
Patch

I was converting some code in WebKit over to using std::condition_variable, and
I noticed a hang i code that did:

if (!m_condition.wait_for(lock, timeout)) {
}

Turns out this is because condition_variable::wait_for returns a cv_status
which is not using enum class. (Both Visual C++ and GCC use enumclass for
cv_status).

The attached patch fixes the bug, but I'm slightly worried about any ABI
implications (mostly mangling).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20131223/daad55af/attachment.html>