[LLVMbugs] [Bug 18228] New: llvm/lib/IR/Instructions.cpp: 2 * return expression wierdness ?

[bugzilla-daemon at llvm.org]

http://llvm.org/bugs/show_bug.cgi?id=18228

            Bug ID: 18228
           Summary: llvm/lib/IR/Instructions.cpp: 2 * return expression
                    wierdness ?
           Product: new-bugs
           Version: trunk
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P
         Component: new bugs
          Assignee: unassignedbugs at nondot.org
          Reporter: dcb314 at hotmail.com
                CC: llvmbugs at cs.uiuc.edu
    Classification: Unclassified

I just ran static analyser "cppcheck" over the llvm trunk source code.
It said many things, including

1.

[llvm/lib/IR/Instructions.cpp:2836]: (style) Same expression 
on both sides of '=='.

Source code is

    return SrcTy->getPointerAddressSpace() == DstTy->getPointerAddressSpace()
&&
           SrcTy->isVectorTy() == DstTy->isVectorTy() &&
           (!SrcTy->isVectorTy() ||
            SrcTy->getVectorNumElements() == SrcTy->getVectorNumElements());

Maybe 

    return SrcTy->getPointerAddressSpace() == DstTy->getPointerAddressSpace()
&&
           SrcTy->isVectorTy() == DstTy->isVectorTy() &&
           (!SrcTy->isVectorTy() ||
            SrcTy->getVectorNumElements() == DstTy->getVectorNumElements());

was intended.

2.

[llvm/lib/IR/Instructions.cpp:2843]: (style) Same expression 
on both sides of '=='.

Duplicate a few lines further down.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20131212/cca69a39/attachment.html>