[LLVMbugs] [Bug 13634] -Wdocumentation assertion when dealing with implicit instantiations of functions

bugzilla-daemon at llvm.org bugzilla-daemon at llvm.org
Thu Aug 23 15:43:02 PDT 2012


Dmitri Gribenko <gribozavr at gmail.com> changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Dmitri Gribenko <gribozavr at gmail.com> 2012-08-23 17:43:02 CDT ---

r162238 | gribozavr | 2012-08-20 15:36:31 -0700 (Mon, 20 Aug 2012) | 5 lines

Attaching comments to declarations: ignore implicit decls.  Decl::isImplicit()
does not return true for all implicit decls currently.

This should fix PR13634 for now, but Decl::isImplicit() should be fixed, too.

r162371 | gribozavr | 2012-08-22 10:44:32 -0700 (Wed, 22 Aug 2012) | 3 lines

Attaching comments to declarations: when documentation is requested for an
implicit instantiation, look for documentation attached to the template.

r162488 | gribozavr | 2012-08-23 15:40:40 -0700 (Thu, 23 Aug 2012) | 9 lines

Attaching comments to decls: since it was decided that Decl::isImplicit should
not be set for implicit instantiations, remove the FIXME.  This should be the
last bit for PR13634.  The actual fix happened in r162238.

Motivation: it might be misleading to mark implicit instantiations as
Decl::isImplicit = true.  Because then, in order to be consistent, we should
mark all instantiated members as implicit.  But the user did actually type the
declaration for the member, but the compiler played with it a little bit.

Configure bugmail: http://llvm.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the llvm-bugs mailing list