[LLVMbugs] [Bug 10188] New: FPPassManager::runOnModule may return incorrect values

[bugzilla-daemon at llvm.org]

http://llvm.org/bugs/show_bug.cgi?id=10188

           Summary: FPPassManager::runOnModule may return incorrect values
           Product: libraries
           Version: trunk
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P
         Component: Core LLVM classes
        AssignedTo: unassignedbugs at nondot.org
        ReportedBy: wujingyue at gmail.com
                CC: llvmbugs at cs.uiuc.edu


Hi, 

In lib/VMCore/PassManager, around Line 1530: 

1531 bool FPPassManager::runOnModule(Module &M) {
1532   bool Changed = doInitialization(M);
1533 
1534   for (Module::iterator I = M.begin(), E = M.end(); I != E; ++I)
1535     runOnFunction(*I);
1536 
1537   return doFinalization(M) || Changed;
1538 }

I think
"runOnFunction(*I)"
should be changed to
"Changed |= runOnFunction(*I)"
because FPPassManager::runOnModule is supposed to return true if any function
gets changed. 

Let me know if I'm understanding it correctly. Thanks much. 

Best,
Jingyue

-- 
Configure bugmail: http://llvm.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.