[LLVMbugs] [Bug 6884] Clang fails to account for no-return destructors in warnings

[bugzilla-daemon at llvm.org]

http://llvm.org/bugs/show_bug.cgi?id=6884

Chandler Carruth <chandlerc at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Chandler Carruth <chandlerc at gmail.com> 2010-05-17 18:52:57 CDT ---
(In reply to comment #6)
> (In reply to comment #3)
> > Created an attachment (id=4870)
 --> (http://llvm.org/bugs/attachment.cgi?id=4870) [details] [details]
> > proposed patch
> > 
> > I've attached a patch that implements this logic for C++ temporaries. I'd
> > appreciate a sanity check on this patch, but it seems to address the specific
> > cases in this bug.
> 
> Sorry for the delay.  Somehow my email notification for this PR got buried in
> my inbox.
> 
> I think the patch is okay as an intermediate solution, but overall I don't
> think it's the right approach.  Instead, destructor calls should be explicitly
> modeled in the CFG (including destructor calls for temporaries).  I'm fine with
> this patch getting committed, but there should be a FIXME comment above the
> code that this should be removed once destructors are properly modeled in the
> CFG.

Thanks, submitted with appropriate FIXME in r104000 so we can deal with this
later when more thoroughly fixing the CFG code.

-- 
Configure bugmail: http://llvm.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.