[LLVMbugs] [Bug 6337] New: SelectionDAG.cpp has opporunity for code refactoring

[bugzilla-daemon at cs.uiuc.edu]

http://llvm.org/bugs/show_bug.cgi?id=6337

           Summary: SelectionDAG.cpp has opporunity for code refactoring
           Product: libraries
           Version: trunk
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Common Code Generator Code
        AssignedTo: unassignedbugs at nondot.org
        ReportedBy: micah.villmow at amd.com
                CC: llvmbugs at cs.uiuc.edu


There are many locations in SelectionDAG that should be using the
getScalarType() function instead of using the ?: operator.
849c849
<   EVT EltVT = VT.isVector() ? VT.getVectorElementType() : VT;
---
>   EVT EltVT = VT.getScalarType();
856c856
<   EVT EltVT = VT.isVector() ? VT.getVectorElementType() : VT;
---
>   EVT EltVT = VT.getScalarType();
870c870
<   EVT EltVT = VT.isVector() ? VT.getVectorElementType() : VT;
---
>   EVT EltVT = VT.getScalarType();
912,913c912
<   EVT EltVT =
<     VT.isVector() ? VT.getVectorElementType() : VT;
---
>   EVT EltVT = VT.getScalarType();
946,947c945
<   EVT EltVT =
<     VT.isVector() ? VT.getVectorElementType() : VT;
---
>   EVT EltVT = VT.getScalarType();
3034,3035c3032
<   unsigned NumBits = VT.isVector() ?
<     VT.getVectorElementType().getSizeInBits() : VT.getSizeInBits();
---
>   unsigned NumBits = VT.getScalarType();


-- 
Configure bugmail: http://llvm.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.