[LLVMbugs] [Bug 777] DiffFilesWithTolerance throws exception, it shouldn't

bugzilla-daemon at cs.uiuc.edu bugzilla-daemon at cs.uiuc.edu
Mon May 15 15:13:27 PDT 2006


rspencer at x10sys.com changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

------- Additional Comments From rspencer at x10sys.com  2006-05-15 17:13 -------
The entire body of this function has a try/catch block around it which catches
std::string. lib/System only throws std::string (I checked) so the catch block
should already catch anything that is thrown by lib/System. 

The function also calls std::memcmp but I could not determine if that function
can throw (I don't think it does). operator delete is also called, but that is
always declared as throw() so it doesn't throw.

To make sure the function doesn't throw anything else, I added a catch(...) to
the end of it and gave a generic message. If this catch block ever gets invoked
(doubt it), we should investigate and determine the actual exception that is
being thrown. I think coverity is being a little over-pessimistic about what
this function can throw.

Patch here:

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

More information about the llvm-bugs mailing list