[llvm-branch-commits] [cfe-branch] r323179 - [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

Thu Feb 1 01:57:56 PST 2018

Hello!

I will try to look into OpenMP tests on Windows. I actually added the note (to the discussion about failing tests)  - how to make the particular test working. But I need to build all this on Windows myself to verify and prepare the patch. Currently I should admit it is much more difficult to build LLVM on Windows than on Linux :(.

Regards,
Olga

-----Original Message-----
From: Jonas Hahnfeld [mailto:hahnjo at hahnjo.de] 
Sent: Thursday, February 1, 2018 12:46 PM
To: Hans Wennborg <hans at chromium.org>
Cc: Joachim Protze <protze at itc.rwth-aachen.de>; Malysheva, Olga <Olga.Malysheva at intel.com>; llvm-branch-commits at lists.llvm.org; hwennborg at google.com
Subject: Re: [llvm-branch-commits] [cfe-branch] r323179 - [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

No, there isn't and I fully agree that this is far from ideal. However, we are only running an x86 Linux cluster and that's where I try to get coverage for.

 From my part, feel free to remove the part about Windows if you think it's better for user experience. I've never used OpenMP on Windows and certainly won't look into issues there.

Thanks,
Jonas

Am 2018-02-01 10:38, schrieb Hans Wennborg:
> Is there a buildbot that tests it regularly on Windows, ideally built 
> with Clang?
> 
> I'm sorry that I seem grumpy about this, but there appears to be a 
> problem here.
> 
> On Thu, Feb 1, 2018 at 10:30 AM, Jonas Hahnfeld <hahnjo at hahnjo.de>
> wrote:
> 
>> I think it actually works _if_ you get Clang to link to the right 
>> runtime library... Adding Joachim and Olga who have been working on 
>> this lately.
>> 
>> Am 2018-02-01 10:26, schrieb Hans Wennborg:
>> As far as I understand, this doesn't actually work on Windows.
>> Should
>> we update the text?
>> 
>> On Tue, Jan 23, 2018 at 8:50 AM, Jonas Hahnfeld via 
>> llvm-branch-commits <llvm-branch-commits at lists.llvm.org> wrote:
>> 
>> Author: hahnfeld
>> Date: Mon Jan 22 23:50:11 2018
>> New Revision: 323179
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=323179&view=rev [1] [1]
>> Log:
>> [ReleaseNotes] Mention OpenMP Tools Interface in runtime library
>> 
>> The OpenMP runtime has no dedicated Release Notes, so add it to 
>> Clang's section about OpenMP.
>> 
>> Differential Revision: https://reviews.llvm.org/D42352 [2] [2]
>> 
>> Modified:
>> cfe/branches/release_60/docs/ReleaseNotes.rst
>> 
>> Modified: cfe/branches/release_60/docs/ReleaseNotes.rst
>> URL:
>> 
>> 
> http://llvm.org/viewvc/llvm-project/cfe/branches/release_60/docs/Relea
> seNotes.rst?rev=323179&r1=323178&r2=323179&view=diff
>> [3]
>> [3]
>> 
>> 
> ======================================================================
> ========
>> --- cfe/branches/release_60/docs/ReleaseNotes.rst (original)
>> +++ cfe/branches/release_60/docs/ReleaseNotes.rst Mon Jan 22
>> 23:50:11 2018
>> @@ -231,6 +231,13 @@ OpenMP Support in Clang
>> - Added support for `reduction`-based clauses on `task`-based 
>> directives from upcoming OpenMP 5.0.
>> 
>> +- The LLVM OpenMP runtime `libomp` now supports the OpenMP Tools
>> Interface (OMPT)
>> +  on x86, x86_64, AArch64, and PPC64 on Linux, Windows, and macOS.
>> If you observe
>> +  a measurable performance impact on one of your applications
>> without a tool
>> +  attached, please rebuild the runtime library with
>> `-DLIBOMP_OMPT_SUPPORT=OFF` and
>> +  file a bug at `LLVM's Bugzilla <https://bugs.llvm.org/>`_ or send
>> a message to the
>> +  `OpenMP development list
>> <http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev [4] 
>> [4]>`_.
>> +
>> Internal API Changes
>> --------------------

--------------------------------------------------------------------
Joint Stock Company Intel A/O
Registered legal address: Krylatsky Hills Business Park,
17 Krylatskaya Str., Bldg 4, Moscow 121614,
Russian Federation

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
An embedded message was scrubbed...
From: Olga Malysheva via Phabricator <reviews at reviews.llvm.org>
Subject: [PATCH] D42427: Fix broken OpenMP runtime test cases for Windows
Date: Thu, 25 Jan 2018 15:32:11 +0000
Size: 4903
URL: <http://lists.llvm.org/pipermail/llvm-branch-commits/attachments/20180201/91a8def1/attachment.mht>