[llvm-branch-commits] [llvm-branch] r276337 - [MSSA] Fix PR28632 in the 3.9 branch.

George Burgess IV via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Thu Jul 21 14:16:41 PDT 2016


Author: gbiv
Date: Thu Jul 21 16:09:24 2016
New Revision: 276337

URL: http://llvm.org/viewvc/llvm-project?rev=276337&view=rev
Log:
[MSSA] Fix PR28632 in the 3.9 branch.

The now-removed assertion was really more for initial debugging; it's
perfectly valid (albeit relatively rare) for `Q.Visited.size()` to be
greater than 1,000. A similar patch hasn't been applied to trunk
because the piece of code this assertion was a part of no longer exists
in trunk.

Fix okayed by Danny, merge to 3.9 okayed by Hans.

Modified:
    llvm/branches/release_39/lib/Transforms/Utils/MemorySSA.cpp

Modified: llvm/branches/release_39/lib/Transforms/Utils/MemorySSA.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/branches/release_39/lib/Transforms/Utils/MemorySSA.cpp?rev=276337&r1=276336&r2=276337&view=diff
==============================================================================
--- llvm/branches/release_39/lib/Transforms/Utils/MemorySSA.cpp (original)
+++ llvm/branches/release_39/lib/Transforms/Utils/MemorySSA.cpp Thu Jul 21 16:09:24 2016
@@ -1225,7 +1225,6 @@ MemoryAccessPair MemorySSA::CachingWalke
     MemoryAccess *CacheAccess = DFI.getPath(N - 1);
     doCacheInsert(CacheAccess, ModifyingAccess, Q, Loc);
   }
-  assert(Q.Visited.size() < 1000 && "Visited too much");
 
   return {ModifyingAccess, Loc};
 }




More information about the llvm-branch-commits mailing list