[llvm-branch-commits] [polly] r259708 - Merged: https://llvm.org/svn/llvm-project/polly/trunk at 259347

Tobias Grosser via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Feb 3 13:43:01 PST 2016

Author: grosser
Date: Wed Feb  3 15:43:01 2016
New Revision: 259708

URL: http://llvm.org/viewvc/llvm-project?rev=259708&view=rev
Merged: https://llvm.org/svn/llvm-project/polly/trunk@259347

ScopInfo: Drop dead code in schedule description

In https://llvm.org/svn/llvm-project/polly/trunk@251870 code was committed to
avoid a failure in the presence of infinite loops, but the test case committed
along with this change passes without the actual change. I looked back into the
code and also checked with the original committer (Johannes), but could not find
the reason why the code is needed. The introduction of LoopStacks for
buildSchedule in one of the next commits will make it even more clear that this
code is not needed, but I remove this ahead of time to facilitate bisecting in
case I missed something.


Modified: polly/branches/release_38/lib/Analysis/ScopInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/polly/branches/release_38/lib/Analysis/ScopInfo.cpp?rev=259708&r1=259707&r2=259708&view=diff
--- polly/branches/release_38/lib/Analysis/ScopInfo.cpp (original)
+++ polly/branches/release_38/lib/Analysis/ScopInfo.cpp Wed Feb  3 15:43:01 2016
@@ -3464,15 +3464,6 @@ void Scop::buildSchedule(
   while (L && NumVisited == L->getNumBlocks()) {
     auto *PL = L->getParentLoop();
-    // Either we have a proper loop and we also build a schedule for the
-    // parent loop or we have a infinite loop that does not have a proper
-    // parent loop. In the former case this conditional will be skipped, in
-    // the latter case however we will break here as we do not build a domain
-    // nor a schedule for a infinite loop.
-    assert(LoopSchedules.count(PL) || LSchedule == nullptr);
-    if (!LoopSchedules.count(PL))
-      break;
     auto &PSchedulePair = LoopSchedules[PL];
     if (LSchedule) {

More information about the llvm-branch-commits mailing list