[llvm-branch-commits] [llvm-branch] r236112 - Attempt #2: Fix ABI compatibility with 3.6.0 by moving new virtual function to end of subclass. NFC

Daniel Sanders daniel.sanders at imgtec.com
Wed Apr 29 08:29:14 PDT 2015


Author: dsanders
Date: Wed Apr 29 10:29:14 2015
New Revision: 236112

URL: http://llvm.org/viewvc/llvm-project?rev=236112&view=rev
Log:
Attempt #2: Fix ABI compatibility with 3.6.0 by moving new virtual function to end of subclass. NFC

The previous attempt at fixing this only moved the problem to the subclass
vtable. We can safely move the function into the subclass so attempt to fix it
that way.


Modified:
    llvm/branches/release_36/include/llvm/Target/TargetLowering.h

Modified: llvm/branches/release_36/include/llvm/Target/TargetLowering.h
URL: http://llvm.org/viewvc/llvm-project/llvm/branches/release_36/include/llvm/Target/TargetLowering.h?rev=236112&r1=236111&r2=236112&view=diff
==============================================================================
--- llvm/branches/release_36/include/llvm/Target/TargetLowering.h (original)
+++ llvm/branches/release_36/include/llvm/Target/TargetLowering.h Wed Apr 29 10:29:14 2015
@@ -2011,12 +2011,6 @@ protected:
   /// Replace/modify any TargetFrameIndex operands with a targte-dependent
   /// sequence of memory operands that is recognized by PrologEpilogInserter.
   MachineBasicBlock *emitPatchPoint(MachineInstr *MI, MachineBasicBlock *MBB) const;
-
-public:
-  /// Returns true if arguments should be sign-extended in lib calls.
-  virtual bool shouldSignExtendTypeInLibCall(EVT Type, bool IsSigned) const {
-    return IsSigned;
-  }
 };
 
 /// This class defines information used to lower LLVM code to legal SelectionDAG
@@ -2812,6 +2806,11 @@ public:
   virtual bool useLoadStackGuardNode() const {
     return false;
   }
+
+  /// Returns true if arguments should be sign-extended in lib calls.
+  virtual bool shouldSignExtendTypeInLibCall(EVT Type, bool IsSigned) const {
+    return IsSigned;
+  }
 };
 
 /// Given an LLVM IR type and return type attributes, compute the return value





More information about the llvm-branch-commits mailing list