[llvm-branch-commits] [llvm-branch] r161895 [1/5] - in /llvm/branches/AMDILBackend/lib/Target: ./ AMDIL/ AMDIL/TargetInfo/

Eric Christopher echristo at apple.com
Mon Aug 20 15:49:47 PDT 2012

On Aug 20, 2012, at 2:26 PM, Eric Christopher <echristo at apple.com> wrote:

> On Aug 14, 2012, at 2:38 PM, Victor Oliveira <Victor.Oliveira at amd.com> wrote:
>> +// We are piggybacking on the CommentFlag enum in MachineInstr.h to
>> +// set bits in AsmPrinterFlags of the MachineInstruction. We will
>> +// start at bit 16 and allocate down while LLVM will start at bit
> Yuck. :)

Few other comments:

a) You'll want to conform to the LLVM coding standards
 - 80-columns, indenting, brace placement, naming, etc.
b) This really is gross. Don't do it.

there's probably more, but it's a first start. Glad to see the branch taking shape for you guys.


More information about the llvm-branch-commits mailing list