[llvm-branch-commits] [llvm-branch] r134489 - /llvm/branches/type-system-rewrite/lib/Linker/LinkModules.cpp

Chris Lattner sabre at nondot.org
Wed Jul 6 00:44:56 PDT 2011


Author: lattner
Date: Wed Jul  6 02:44:56 2011
New Revision: 134489

URL: http://llvm.org/viewvc/llvm-project?rev=134489&view=rev
Log:
tidy up.  The linker is now 'done', it just needs to be debugged and
its testcases need to be updated.  It's doing more but is much shorter
than on mainline.

Modified:
    llvm/branches/type-system-rewrite/lib/Linker/LinkModules.cpp

Modified: llvm/branches/type-system-rewrite/lib/Linker/LinkModules.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/branches/type-system-rewrite/lib/Linker/LinkModules.cpp?rev=134489&r1=134488&r2=134489&view=diff
==============================================================================
--- llvm/branches/type-system-rewrite/lib/Linker/LinkModules.cpp (original)
+++ llvm/branches/type-system-rewrite/lib/Linker/LinkModules.cpp Wed Jul  6 02:44:56 2011
@@ -671,9 +671,6 @@
   
   // If there is no linkage to be performed or we are linking from the source,
   // bring SF over.
-
-  // Function does not already exist, simply insert an function signature
-  // identical to SF into the dest module.
   Function *NewDF = Function::Create(TypeMap.get(SF->getFunctionType()),
                                      SF->getLinkage(), SF->getName(), DstM);
   CopyGVAttributes(NewDF, SF);
@@ -736,7 +733,7 @@
   // Loop over all of the globals in the src module, mapping them over as we go
   for (Module::const_global_iterator I = SrcM->global_begin(),
        E = SrcM->global_end(); I != E; ++I) {
-    if (!I->hasInitializer()) continue;      // Only process initialized GV's
+    if (!I->hasInitializer()) continue;      // Only process initialized GV's.
     
     // Grab destination global variable.
     GlobalVariable *DGV = cast<GlobalVariable>(ValueMap[I]);





More information about the llvm-branch-commits mailing list