[llvm-branch-commits] [cfe-branch] r71418 - in /cfe/branches/Apple/Dib: lib/Analysis/CFRefCount.cpp test/Analysis/retain-release-gc-only.m

[Bill Wendling]

On May 10, 2009, at 8:43 PM, Mike Stump wrote:

> Author: mrs
> Date: Sun May 10 22:43:16 2009
> New Revision: 71418
>
> URL: http://llvm.org/viewvc/llvm-project?rev=71418&view=rev
> Log:
> Merge in 71397:
>
> Add special warning about returning a retained object where a GC'ed  
> object is expected.
>
> Modified:
>    cfe/branches/Apple/Dib/lib/Analysis/CFRefCount.cpp
>    cfe/branches/Apple/Dib/test/Analysis/retain-release-gc-only.m
>
> Modified: cfe/branches/Apple/Dib/lib/Analysis/CFRefCount.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/branches/Apple/Dib/lib/Analysis/CFRefCount.cpp?rev=71418&r1=71417&r2=71418&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- cfe/branches/Apple/Dib/lib/Analysis/CFRefCount.cpp (original)
> +++ cfe/branches/Apple/Dib/lib/Analysis/CFRefCount.cpp Sun May 10  
> 22:43:16 2009
> @@ -2517,9 +2517,10 @@
>   else if (RV->getKind() == RefVal::ErrorGCLeakReturned) {
>     ObjCMethodDecl& MD = cast<ObjCMethodDecl>(BRC.getCodeDecl());
>     os << " and returned from method '" <<  
> MD.getSelector().getAsString()
> -       << "' is potentially leaked when using garbage collection.   
> Callers"
> -          " of this method do not expect a +1 retain count since  
> the return"
> -          " type is an Objective-C object reference";
> +       << "' is potentially leaked when using garbage collection.   
> Callers "
> +          "of this method do not expect a returned object with a +1  
> retain "

Shouldn't this be "an object"?

-bw