[lldb-dev] [Bug 49046] New: Building lldb-vscode for windows is broken on 12.x

[via lldb-dev]

https://bugs.llvm.org/show_bug.cgi?id=49046

            Bug ID: 49046
           Summary: Building lldb-vscode for windows is broken on 12.x
           Product: lldb
           Version: 10.0
          Hardware: PC
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: All Bugs
          Assignee: lldb-dev at lists.llvm.org
          Reporter: martin at martin.st
                CC: a20012251 at gmail.com, jdevlieghere at apple.com,
                    llvm-bugs at lists.llvm.org, tstellar at redhat.com
            Blocks: 48902

Building the 12.x branch for windows currently breaks when building
lldb-vscode; this was fixed on the main branch soon after the branch.

The build break I saw was fixed by ab5591e1d8f5abcfa9e75193d3e8a29087b61425,
but there were a few later follow up commits on the same area as well - so I'd
suggest backporting all of them for consistency's sake:

commit ab5591e1d8f5abcfa9e75193d3e8a29087b61425 
Author: Walter Erquinigo <a20012251 at gmail.com> 
Date:   Wed Jan 27 13:02:45 2021 -0800

    Fix runInTerminal failures on Windows 

commit 0bca9a7ce2eeaa9f1d732ffbc17769560a2b236e
Author: Walter Erquinigo <a20012251 at gmail.com> 
Date:   Thu Jan 28 09:24:30 2021 -0800

    Fix lldb-vscode builds on Windows targeting POSIX 

commit 36496cc2992d6fa26e6024971efcfc7d15f69888
Author: Walter Erquinigo <a20012251 at gmail.com>
Date:   Thu Feb 4 10:07:07 2021 -0800

    [lldb-vscode] correctly use Windows macros


Referenced Bugs:

https://bugs.llvm.org/show_bug.cgi?id=48902
[Bug 48902] [meta] 12.0.0 Release Blockers
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20210204/5b2e0cdd/attachment.html>