[lldb-dev] [Bug 44690] New: Include guards missing for compression.h

[via lldb-dev]

https://bugs.llvm.org/show_bug.cgi?id=44690

            Bug ID: 44690
           Summary: Include guards missing for compression.h
           Product: lldb
           Version: 10.0
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P
         Component: All Bugs
          Assignee: lldb-dev at lists.llvm.org
          Reporter: ggreif at gmail.com
                CC: jdevlieghere at apple.com, llvm-bugs at lists.llvm.org

See:

llvm-project/lldb/tools/debugserver/source/RNBRemote.cpp
Lines 43 to 45 in f15b60b
>  
> #include <compression.h> 
>  

Include protection is missing (HAVE_LIBCOMPRESSION).

How it should be:

llvm-project/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
Lines 49 to 51 in f15b60b
> #if defined(HAVE_LIBCOMPRESSION) 
> #include <compression.h> 
> #endif 

This was detected while updating the nixpkgs for llvm-10.

This change would imply more changes around lines 715 to 761.

Originally filed as https://github.com/llvm/llvm-project/issues/112

I suggest back porting from master to release-10.0 branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20200128/b12a8575/attachment.html>