[lldb-dev] LLDB finish_swig and Python module installation broken for multi-configuration generators

[Ted Woodward via lldb-dev]

The build step works with r374250, but the install step fails. It needs CMAKE_CFG_INTDIR added to:
      install(DIRECTORY ${CMAKE_BINARY_DIR}/${LLDB_PYTHON_RELATIVE_PATH}/
              DESTINATION ${LLDB_PYTHON_RELATIVE_PATH}
              COMPONENT lldb-scripts)


> -----Original Message-----
> From: Michał Górny <mgorny at gentoo.org>
> Sent: Friday, October 11, 2019 8:35 AM
> To: Ted Woodward <tedwood at quicinc.com>; LLDB <lldb-
> dev at lists.llvm.org>; hhb at google.com; antonio.afonso at gmail.com
> Subject: [EXT] Re: LLDB finish_swig and Python module installation broken for
> multi-configuration generators
>
> On Thu, 2019-10-10 at 23:11 +0000, Ted Woodward wrote:
> > Starting in r372835 (Fix installing Python modules on systems using /usr/lib),
> the finish_swig and installation steps using multi-configuration generators (like
> Visual Studio or XCode) are broken.
> >
> > The problem is the symlink and install steps look for liblldb and site-packages
> the wrong directories.
> >
> > For the symlink, I get this output:
> >          Making symlink from ..\..\..\bin\liblldb.dll to
> > i:\obj\lib\site-packages\lldb\_lldb.pyd
> > ...
> >          WindowsError: [Error 2] The system cannot find the file specified:
> '..\\..\\..\\bin\\liblldb.dll'
> >
> > Because the cwd is I:\obj\Lib\site-packages\lldb, not the correct
> I:\obj\Release\Lib\site-packages\lldb. liblldb.dll is in i:\obj\Release\bin, not
> i:\obj\bin. Also, the link itself should be in i:\obj\Release\lib, not i:\obj\lib.
> >
> > The problem is the cmake code went from using
> LLVM_LIBRARY_OUTPUT_INTDIR to CMAKE_BINARY_DIR. CMAKE_BINARY_DIR
> is not complete for multi-configuration generators - you need to specify the
> configuration as well.
> >
> [...]
> > Michal, please try this and see if it still works for the issue you fixed in
> r372835.
>
> Actually, I see that Haibo has already addressed this 2 days ago.  Could you
> test if his solution (r374250) works for you?
>
> --
> Best regards,
> Michał Górny