[lldb-dev] [Lldb-commits] [lldb] r360757 - Group forward declarations in one namespace lldb_private {}
Jim Ingham via lldb-dev
lldb-dev at lists.llvm.org
Wed May 15 10:47:23 PDT 2019
This commit makes things look a little cleaner, but do we need any of these forward declarations at all?
Most of these files either directly include lldb-forward.h or get it from lldb-types.h or lldb-defines.h (which includes lldb-types.h). As a general practice we've been getting all the lldb_private type forward declarations this way rather than cluttering up the .h files with individual forward declarations. If we are going to keep doing it that way - which I can't see any reason not to do, then we should just delete all these forward defines, right?
Jim
> On May 15, 2019, at 2:15 AM, Fangrui Song via lldb-commits <lldb-commits at lists.llvm.org> wrote:
>
> Author: maskray
> Date: Wed May 15 02:15:13 2019
> New Revision: 360757
>
> URL: http://llvm.org/viewvc/llvm-project?rev=360757&view=rev
> Log:
> Group forward declarations in one namespace lldb_private {}
>
> Modified:
> lldb/trunk/include/lldb/Core/Address.h
> lldb/trunk/include/lldb/Core/AddressRange.h
> lldb/trunk/include/lldb/Core/AddressResolver.h
> lldb/trunk/include/lldb/Core/AddressResolverFileLine.h
> lldb/trunk/include/lldb/Core/AddressResolverName.h
> lldb/trunk/include/lldb/Core/Communication.h
> lldb/trunk/include/lldb/Core/Debugger.h
> lldb/trunk/include/lldb/Core/Disassembler.h
> lldb/trunk/include/lldb/Core/EmulateInstruction.h
> lldb/trunk/include/lldb/Core/FileLineResolver.h
> lldb/trunk/include/lldb/Core/FileSpecList.h
> lldb/trunk/include/lldb/Core/FormatEntity.h
> lldb/trunk/include/lldb/Core/Module.h
> lldb/trunk/include/lldb/Core/ModuleList.h
> lldb/trunk/include/lldb/Core/Opcode.h
> lldb/trunk/include/lldb/Core/PluginManager.h
> lldb/trunk/include/lldb/Core/SearchFilter.h
> lldb/trunk/include/lldb/Core/Section.h
> lldb/trunk/include/lldb/Core/SourceManager.h
> lldb/trunk/include/lldb/Core/StreamAsynchronousIO.h
> lldb/trunk/include/lldb/Core/UserSettingsController.h
> lldb/trunk/include/lldb/Core/Value.h
> lldb/trunk/include/lldb/Core/ValueObject.h
> lldb/trunk/include/lldb/Core/ValueObjectCast.h
> lldb/trunk/include/lldb/Core/ValueObjectConstResult.h
> lldb/trunk/include/lldb/Core/ValueObjectConstResultCast.h
> lldb/trunk/include/lldb/Core/ValueObjectConstResultChild.h
> lldb/trunk/include/lldb/Core/ValueObjectConstResultImpl.h
> lldb/trunk/include/lldb/Core/ValueObjectDynamicValue.h
> lldb/trunk/include/lldb/Core/ValueObjectList.h
> lldb/trunk/include/lldb/Core/ValueObjectMemory.h
> lldb/trunk/include/lldb/Core/ValueObjectRegister.h
> lldb/trunk/include/lldb/Core/ValueObjectSyntheticFilter.h
> lldb/trunk/include/lldb/Core/ValueObjectVariable.h
> lldb/trunk/include/lldb/Target/DynamicLoader.h
> lldb/trunk/include/lldb/Utility/Broadcaster.h
> lldb/trunk/include/lldb/Utility/Connection.h
> lldb/trunk/include/lldb/Utility/DataExtractor.h
> lldb/trunk/include/lldb/Utility/Event.h
> lldb/trunk/include/lldb/Utility/JSON.h
> lldb/trunk/include/lldb/Utility/Listener.h
> lldb/trunk/include/lldb/Utility/StringList.h
> lldb/trunk/include/lldb/Utility/StructuredData.h
> lldb/trunk/include/lldb/Utility/UserID.h
>
> Modified: lldb/trunk/include/lldb/Core/Address.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/Address.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/Address.h (original)
> +++ lldb/trunk/include/lldb/Core/Address.h Wed May 15 02:15:13 2019
> @@ -19,36 +19,15 @@
>
> namespace lldb_private {
> class Block;
> -}
> -namespace lldb_private {
> class CompileUnit;
> -}
> -namespace lldb_private {
> class ExecutionContextScope;
> -}
> -namespace lldb_private {
> class Function;
> -}
> -namespace lldb_private {
> class SectionList;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -namespace lldb_private {
> class Symbol;
> -}
> -namespace lldb_private {
> class SymbolContext;
> -}
> -namespace lldb_private {
> class Target;
> -}
> -namespace lldb_private {
> struct LineEntry;
> -}
> -
> -namespace lldb_private {
>
> /// \class Address Address.h "lldb/Core/Address.h"
> /// A section + offset based address class.
>
> Modified: lldb/trunk/include/lldb/Core/AddressRange.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/AddressRange.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/AddressRange.h (original)
> +++ lldb/trunk/include/lldb/Core/AddressRange.h Wed May 15 02:15:13 2019
> @@ -17,15 +17,8 @@
>
> namespace lldb_private {
> class SectionList;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -namespace lldb_private {
> class Target;
> -}
> -
> -namespace lldb_private {
>
> /// \class AddressRange AddressRange.h "lldb/Core/AddressRange.h"
> /// A section + offset based address range class.
>
> Modified: lldb/trunk/include/lldb/Core/AddressResolver.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/AddressResolver.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/AddressResolver.h (original)
> +++ lldb/trunk/include/lldb/Core/AddressResolver.h Wed May 15 02:15:13 2019
> @@ -18,11 +18,7 @@
>
> namespace lldb_private {
> class ModuleList;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -namespace lldb_private {
>
> /// \class AddressResolver AddressResolver.h "lldb/Core/AddressResolver.h"
> /// This class works with SearchFilter to resolve function names and source
>
> Modified: lldb/trunk/include/lldb/Core/AddressResolverFileLine.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/AddressResolverFileLine.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/AddressResolverFileLine.h (original)
> +++ lldb/trunk/include/lldb/Core/AddressResolverFileLine.h Wed May 15 02:15:13 2019
> @@ -18,15 +18,8 @@
>
> namespace lldb_private {
> class Address;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -namespace lldb_private {
> class SymbolContext;
> -}
> -
> -namespace lldb_private {
>
> /// \class AddressResolverFileLine AddressResolverFileLine.h
> /// "lldb/Core/AddressResolverFileLine.h" This class finds address for source
>
> Modified: lldb/trunk/include/lldb/Core/AddressResolverName.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/AddressResolverName.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/AddressResolverName.h (original)
> +++ lldb/trunk/include/lldb/Core/AddressResolverName.h Wed May 15 02:15:13 2019
> @@ -17,15 +17,8 @@
>
> namespace lldb_private {
> class Address;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -namespace lldb_private {
> class SymbolContext;
> -}
> -
> -namespace lldb_private {
>
> /// \class AddressResolverName AddressResolverName.h
> /// "lldb/Core/AddressResolverName.h" This class finds addresses for a given
>
> Modified: lldb/trunk/include/lldb/Core/Communication.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/Communication.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/Communication.h (original)
> +++ lldb/trunk/include/lldb/Core/Communication.h Wed May 15 02:15:13 2019
> @@ -27,15 +27,8 @@
>
> namespace lldb_private {
> class Connection;
> -}
> -namespace lldb_private {
> class ConstString;
> -}
> -namespace lldb_private {
> class Status;
> -}
> -
> -namespace lldb_private {
>
> /// \class Communication Communication.h "lldb/Core/Communication.h" An
> /// abstract communications class.
>
> Modified: lldb/trunk/include/lldb/Core/Debugger.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/Debugger.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/Debugger.h (original)
> +++ lldb/trunk/include/lldb/Core/Debugger.h Wed May 15 02:15:13 2019
> @@ -45,34 +45,21 @@
> #include <stddef.h>
> #include <stdio.h>
>
> -namespace lldb_private {
> -class Address;
> +namespace llvm {
> +class raw_ostream;
> }
> +
> namespace lldb_private {
> +class Address;
> class CommandInterpreter;
> -}
> -namespace lldb_private {
> class Process;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -namespace lldb_private {
> class SymbolContext;
> -}
> -namespace lldb_private {
> class Target;
> -}
> -namespace lldb_private {
> +
> namespace repro {
> class DataRecorder;
> }
> -} // namespace lldb_private
> -namespace llvm {
> -class raw_ostream;
> -}
> -
> -namespace lldb_private {
>
> /// \class Debugger Debugger.h "lldb/Core/Debugger.h"
> /// A class to manage flag bits.
>
> Modified: lldb/trunk/include/lldb/Core/Disassembler.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/Disassembler.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/Disassembler.h (original)
> +++ lldb/trunk/include/lldb/Core/Disassembler.h Wed May 15 02:15:13 2019
> @@ -38,41 +38,21 @@
> #include <stdint.h>
> #include <stdio.h>
>
> -namespace lldb_private {
> -class AddressRange;
> +namespace llvm {
> +template <typename T> class SmallVectorImpl;
> }
> +
> namespace lldb_private {
> +class AddressRange;
> class DataExtractor;
> -}
> -namespace lldb_private {
> class Debugger;
> -}
> -namespace lldb_private {
> class Disassembler;
> -}
> -namespace lldb_private {
> class Module;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -namespace lldb_private {
> class SymbolContext;
> -}
> -namespace lldb_private {
> class SymbolContextList;
> -}
> -namespace lldb_private {
> class Target;
> -}
> -namespace lldb_private {
> struct RegisterInfo;
> -}
> -namespace llvm {
> -template <typename T> class SmallVectorImpl;
> -}
> -
> -namespace lldb_private {
>
> class Instruction {
> public:
>
> Modified: lldb/trunk/include/lldb/Core/EmulateInstruction.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/EmulateInstruction.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/EmulateInstruction.h (original)
> +++ lldb/trunk/include/lldb/Core/EmulateInstruction.h Wed May 15 02:15:13 2019
> @@ -23,26 +23,14 @@
>
> #include <stddef.h>
> #include <stdint.h>
> +
> namespace lldb_private {
> class OptionValueDictionary;
> -}
> -namespace lldb_private {
> class RegisterContext;
> -}
> -namespace lldb_private {
> class RegisterValue;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -namespace lldb_private {
> class Target;
> -}
> -namespace lldb_private {
> class UnwindPlan;
> -}
> -
> -namespace lldb_private {
>
> /// \class EmulateInstruction EmulateInstruction.h
> /// "lldb/Core/EmulateInstruction.h"
>
> Modified: lldb/trunk/include/lldb/Core/FileLineResolver.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/FileLineResolver.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/FileLineResolver.h (original)
> +++ lldb/trunk/include/lldb/Core/FileLineResolver.h Wed May 15 02:15:13 2019
> @@ -18,12 +18,7 @@
>
> namespace lldb_private {
> class Address;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -
> -namespace lldb_private {
>
> /// \class FileLineResolver FileLineResolver.h "lldb/Core/FileLineResolver.h"
> /// This class finds address for source file and line. Optionally, it will
>
> Modified: lldb/trunk/include/lldb/Core/FileSpecList.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/FileSpecList.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/FileSpecList.h (original)
> +++ lldb/trunk/include/lldb/Core/FileSpecList.h Wed May 15 02:15:13 2019
> @@ -18,9 +18,6 @@
>
> namespace lldb_private {
> class Stream;
> -}
> -
> -namespace lldb_private {
>
> /// \class FileSpecList FileSpecList.h "lldb/Core/FileSpecList.h"
> /// A file collection class.
>
> Modified: lldb/trunk/include/lldb/Core/FormatEntity.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/FormatEntity.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/FormatEntity.h (original)
> +++ lldb/trunk/include/lldb/Core/FormatEntity.h Wed May 15 02:15:13 2019
> @@ -23,20 +23,10 @@
>
> namespace lldb_private {
> class Address;
> -}
> -namespace lldb_private {
> class ExecutionContext;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -namespace lldb_private {
> class StringList;
> -}
> -namespace lldb_private {
> class SymbolContext;
> -}
> -namespace lldb_private {
> class ValueObject;
> }
> namespace llvm {
>
> Modified: lldb/trunk/include/lldb/Core/Module.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/Module.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/Module.h (original)
> +++ lldb/trunk/include/lldb/Core/Module.h Wed May 15 02:15:13 2019
> @@ -39,57 +39,22 @@
>
> namespace lldb_private {
> class CompilerDeclContext;
> -}
> -namespace lldb_private {
> class Function;
> -}
> -namespace lldb_private {
> class Log;
> -}
> -namespace lldb_private {
> class ObjectFile;
> -}
> -namespace lldb_private {
> class RegularExpression;
> -}
> -namespace lldb_private {
> class SectionList;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -namespace lldb_private {
> class Symbol;
> -}
> -namespace lldb_private {
> class SymbolContext;
> -}
> -namespace lldb_private {
> class SymbolContextList;
> -}
> -namespace lldb_private {
> class SymbolFile;
> -}
> -namespace lldb_private {
> class SymbolVendor;
> -}
> -namespace lldb_private {
> class Symtab;
> -}
> -namespace lldb_private {
> class Target;
> -}
> -namespace lldb_private {
> class TypeList;
> -}
> -namespace lldb_private {
> class TypeMap;
> -}
> -namespace lldb_private {
> class VariableList;
> -}
> -
> -namespace lldb_private {
>
> /// \class Module Module.h "lldb/Core/Module.h"
> /// A class that describes an executable image and its associated
>
> Modified: lldb/trunk/include/lldb/Core/ModuleList.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/ModuleList.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/ModuleList.h (original)
> +++ lldb/trunk/include/lldb/Core/ModuleList.h Wed May 15 02:15:13 2019
> @@ -31,48 +31,19 @@
>
> namespace lldb_private {
> class ConstString;
> -}
> -namespace lldb_private {
> class FileSpecList;
> -}
> -namespace lldb_private {
> class Function;
> -}
> -namespace lldb_private {
> class Log;
> -}
> -namespace lldb_private {
> class Module;
> -}
> -namespace lldb_private {
> class RegularExpression;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -namespace lldb_private {
> class SymbolContext;
> -}
> -namespace lldb_private {
> class SymbolContextList;
> -}
> -namespace lldb_private {
> class SymbolFile;
> -}
> -namespace lldb_private {
> class Target;
> -}
> -namespace lldb_private {
> class TypeList;
> -}
> -namespace lldb_private {
> class UUID;
> -}
> -namespace lldb_private {
> class VariableList;
> -}
> -
> -namespace lldb_private {
>
> class ModuleListProperties : public Properties {
> public:
>
> Modified: lldb/trunk/include/lldb/Core/Opcode.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/Opcode.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/Opcode.h (original)
> +++ lldb/trunk/include/lldb/Core/Opcode.h Wed May 15 02:15:13 2019
> @@ -18,18 +18,13 @@
> #include <stdint.h>
> #include <string.h>
>
> -namespace lldb_private {
> -class DataExtractor;
> -}
> -namespace lldb_private {
> -class Stream;
> -}
> -
> namespace lldb {
> class SBInstruction;
> }
>
> namespace lldb_private {
> +class DataExtractor;
> +class Stream;
>
> class Opcode {
> public:
>
> Modified: lldb/trunk/include/lldb/Core/PluginManager.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/PluginManager.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/PluginManager.h (original)
> +++ lldb/trunk/include/lldb/Core/PluginManager.h Wed May 15 02:15:13 2019
> @@ -22,17 +22,9 @@
>
> namespace lldb_private {
> class CommandInterpreter;
> -}
> -namespace lldb_private {
> class ConstString;
> -}
> -namespace lldb_private {
> class Debugger;
> -}
> -namespace lldb_private {
> class StringList;
> -}
> -namespace lldb_private {
>
> class PluginManager {
> public:
>
> Modified: lldb/trunk/include/lldb/Core/SearchFilter.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/SearchFilter.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/SearchFilter.h (original)
> +++ lldb/trunk/include/lldb/Core/SearchFilter.h Wed May 15 02:15:13 2019
> @@ -19,32 +19,14 @@
>
> namespace lldb_private {
> class Address;
> -}
> -namespace lldb_private {
> class Breakpoint;
> -}
> -namespace lldb_private {
> class CompileUnit;
> -}
> -namespace lldb_private {
> class Status;
> -}
> -namespace lldb_private {
> class Function;
> -}
> -namespace lldb_private {
> class ModuleList;
> -}
> -namespace lldb_private {
> class SearchFilter;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -namespace lldb_private {
> class SymbolContext;
> -}
> -namespace lldb_private {
> class Target;
> }
>
>
> Modified: lldb/trunk/include/lldb/Core/Section.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/Section.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/Section.h (original)
> +++ lldb/trunk/include/lldb/Core/Section.h Wed May 15 02:15:13 2019
> @@ -26,24 +26,11 @@
>
> namespace lldb_private {
> class Address;
> -}
> -namespace lldb_private {
> class DataExtractor;
> -}
> -namespace lldb_private {
> class ObjectFile;
> -}
> -namespace lldb_private {
> class Section;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -namespace lldb_private {
> class Target;
> -}
> -
> -namespace lldb_private {
>
> class SectionList {
> public:
>
> Modified: lldb/trunk/include/lldb/Core/SourceManager.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/SourceManager.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/SourceManager.h (original)
> +++ lldb/trunk/include/lldb/Core/SourceManager.h Wed May 15 02:15:13 2019
> @@ -24,18 +24,9 @@
>
> namespace lldb_private {
> class RegularExpression;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -namespace lldb_private {
> class SymbolContextList;
> -}
> -namespace lldb_private {
> class Target;
> -}
> -
> -namespace lldb_private {
>
> class SourceManager {
> public:
>
> Modified: lldb/trunk/include/lldb/Core/StreamAsynchronousIO.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/StreamAsynchronousIO.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/StreamAsynchronousIO.h (original)
> +++ lldb/trunk/include/lldb/Core/StreamAsynchronousIO.h Wed May 15 02:15:13 2019
> @@ -17,9 +17,6 @@
>
> namespace lldb_private {
> class Debugger;
> -}
> -
> -namespace lldb_private {
>
> class StreamAsynchronousIO : public Stream {
> public:
>
> Modified: lldb/trunk/include/lldb/Core/UserSettingsController.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/UserSettingsController.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/UserSettingsController.h (original)
> +++ lldb/trunk/include/lldb/Core/UserSettingsController.h Wed May 15 02:15:13 2019
> @@ -22,17 +22,9 @@
>
> namespace lldb_private {
> class CommandInterpreter;
> -}
> -namespace lldb_private {
> class ConstString;
> -}
> -namespace lldb_private {
> class ExecutionContext;
> -}
> -namespace lldb_private {
> class Property;
> -}
> -namespace lldb_private {
> class Stream;
> }
>
>
> Modified: lldb/trunk/include/lldb/Core/Value.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/Value.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/Value.h (original)
> +++ lldb/trunk/include/lldb/Core/Value.h Wed May 15 02:15:13 2019
> @@ -26,20 +26,10 @@
>
> namespace lldb_private {
> class DataExtractor;
> -}
> -namespace lldb_private {
> class ExecutionContext;
> -}
> -namespace lldb_private {
> class Module;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -namespace lldb_private {
> class Type;
> -}
> -namespace lldb_private {
> class Variable;
> }
>
>
> Modified: lldb/trunk/include/lldb/Core/ValueObject.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/ValueObject.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/ValueObject.h (original)
> +++ lldb/trunk/include/lldb/Core/ValueObject.h Wed May 15 02:15:13 2019
> @@ -39,40 +39,19 @@
>
> #include <stddef.h>
> #include <stdint.h>
> +
> namespace lldb_private {
> class Declaration;
> -}
> -namespace lldb_private {
> class DumpValueObjectOptions;
> -}
> -namespace lldb_private {
> class EvaluateExpressionOptions;
> -}
> -namespace lldb_private {
> class ExecutionContextScope;
> -}
> -namespace lldb_private {
> class Log;
> -}
> -namespace lldb_private {
> class Scalar;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -namespace lldb_private {
> class SymbolContextScope;
> -}
> -namespace lldb_private {
> class TypeFormatImpl;
> -}
> -namespace lldb_private {
> class TypeSummaryImpl;
> -}
> -namespace lldb_private {
> class TypeSummaryOptions;
> -}
> -namespace lldb_private {
>
> /// ValueObject:
> ///
>
> Modified: lldb/trunk/include/lldb/Core/ValueObjectCast.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/ValueObjectCast.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/ValueObjectCast.h (original)
> +++ lldb/trunk/include/lldb/Core/ValueObjectCast.h Wed May 15 02:15:13 2019
> @@ -20,9 +20,6 @@
>
> namespace lldb_private {
> class ConstString;
> -}
> -
> -namespace lldb_private {
>
> // A ValueObject that represents a given value represented as a different type.
> class ValueObjectCast : public ValueObject {
>
> Modified: lldb/trunk/include/lldb/Core/ValueObjectConstResult.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/ValueObjectConstResult.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/ValueObjectConstResult.h (original)
> +++ lldb/trunk/include/lldb/Core/ValueObjectConstResult.h Wed May 15 02:15:13 2019
> @@ -26,14 +26,8 @@
>
> namespace lldb_private {
> class DataExtractor;
> -}
> -namespace lldb_private {
> class ExecutionContextScope;
> -}
> -namespace lldb_private {
> class Module;
> -}
> -namespace lldb_private {
>
> // A frozen ValueObject copied into host memory
> class ValueObjectConstResult : public ValueObject {
>
> Modified: lldb/trunk/include/lldb/Core/ValueObjectConstResultCast.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/ValueObjectConstResultCast.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/ValueObjectConstResultCast.h (original)
> +++ lldb/trunk/include/lldb/Core/ValueObjectConstResultCast.h Wed May 15 02:15:13 2019
> @@ -22,15 +22,8 @@
>
> namespace lldb_private {
> class DataExtractor;
> -}
> -namespace lldb_private {
> class Status;
> -}
> -namespace lldb_private {
> class ValueObject;
> -}
> -
> -namespace lldb_private {
>
> class ValueObjectConstResultCast : public ValueObjectCast {
> public:
>
> Modified: lldb/trunk/include/lldb/Core/ValueObjectConstResultChild.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/ValueObjectConstResultChild.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/ValueObjectConstResultChild.h (original)
> +++ lldb/trunk/include/lldb/Core/ValueObjectConstResultChild.h Wed May 15 02:15:13 2019
> @@ -19,17 +19,11 @@
>
> #include <stddef.h>
> #include <stdint.h>
> +
> namespace lldb_private {
> class DataExtractor;
> -}
> -namespace lldb_private {
> class Status;
> -}
> -namespace lldb_private {
> class ValueObject;
> -}
> -
> -namespace lldb_private {
>
> // A child of a ValueObjectConstResult.
> class ValueObjectConstResultChild : public ValueObjectChild {
>
> Modified: lldb/trunk/include/lldb/Core/ValueObjectConstResultImpl.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/ValueObjectConstResultImpl.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/ValueObjectConstResultImpl.h (original)
> +++ lldb/trunk/include/lldb/Core/ValueObjectConstResultImpl.h Wed May 15 02:15:13 2019
> @@ -19,14 +19,8 @@
> #include <stdint.h>
> namespace lldb_private {
> class CompilerType;
> -}
> -namespace lldb_private {
> class DataExtractor;
> -}
> -namespace lldb_private {
> class Status;
> -}
> -namespace lldb_private {
> class ValueObject;
> }
>
>
> Modified: lldb/trunk/include/lldb/Core/ValueObjectDynamicValue.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/ValueObjectDynamicValue.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/ValueObjectDynamicValue.h (original)
> +++ lldb/trunk/include/lldb/Core/ValueObjectDynamicValue.h Wed May 15 02:15:13 2019
> @@ -26,14 +26,8 @@
>
> namespace lldb_private {
> class DataExtractor;
> -}
> -namespace lldb_private {
> class Declaration;
> -}
> -namespace lldb_private {
> class Status;
> -}
> -namespace lldb_private {
>
> // A ValueObject that represents memory at a given address, viewed as some
> // set lldb type.
>
> Modified: lldb/trunk/include/lldb/Core/ValueObjectList.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/ValueObjectList.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/ValueObjectList.h (original)
> +++ lldb/trunk/include/lldb/Core/ValueObjectList.h Wed May 15 02:15:13 2019
> @@ -18,9 +18,6 @@
>
> namespace lldb_private {
> class ValueObject;
> -}
> -
> -namespace lldb_private {
>
> // A collection of ValueObject values that
> class ValueObjectList {
>
> Modified: lldb/trunk/include/lldb/Core/ValueObjectMemory.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/ValueObjectMemory.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/ValueObjectMemory.h (original)
> +++ lldb/trunk/include/lldb/Core/ValueObjectMemory.h Wed May 15 02:15:13 2019
> @@ -23,9 +23,6 @@
>
> namespace lldb_private {
> class ExecutionContextScope;
> -}
> -
> -namespace lldb_private {
>
> // A ValueObject that represents memory at a given address, viewed as some
> // set lldb type.
>
> Modified: lldb/trunk/include/lldb/Core/ValueObjectRegister.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/ValueObjectRegister.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/ValueObjectRegister.h (original)
> +++ lldb/trunk/include/lldb/Core/ValueObjectRegister.h Wed May 15 02:15:13 2019
> @@ -23,21 +23,10 @@
>
> namespace lldb_private {
> class DataExtractor;
> -}
> -namespace lldb_private {
> class Status;
> -}
> -namespace lldb_private {
> class ExecutionContextScope;
> -}
> -namespace lldb_private {
> class Scalar;
> -}
> -namespace lldb_private {
> class Stream;
> -}
> -
> -namespace lldb_private {
>
> // A ValueObject that contains a root variable that may or may not
> // have children.
>
> Modified: lldb/trunk/include/lldb/Core/ValueObjectSyntheticFilter.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/ValueObjectSyntheticFilter.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/ValueObjectSyntheticFilter.h (original)
> +++ lldb/trunk/include/lldb/Core/ValueObjectSyntheticFilter.h Wed May 15 02:15:13 2019
> @@ -26,14 +26,8 @@
>
> namespace lldb_private {
> class Declaration;
> -}
> -namespace lldb_private {
> class Status;
> -}
> -namespace lldb_private {
> class SyntheticChildrenFrontEnd;
> -}
> -namespace lldb_private {
>
> // A ValueObject that obtains its children from some source other than
> // real information
>
> Modified: lldb/trunk/include/lldb/Core/ValueObjectVariable.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/ValueObjectVariable.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Core/ValueObjectVariable.h (original)
> +++ lldb/trunk/include/lldb/Core/ValueObjectVariable.h Wed May 15 02:15:13 2019
> @@ -23,21 +23,10 @@
>
> namespace lldb_private {
> class DataExtractor;
> -}
> -namespace lldb_private {
> class Declaration;
> -}
> -namespace lldb_private {
> class Status;
> -}
> -namespace lldb_private {
> class ExecutionContextScope;
> -}
> -namespace lldb_private {
> class SymbolContextScope;
> -}
> -
> -namespace lldb_private {
>
> // A ValueObject that contains a root variable that may or may not
> // have children.
>
> Modified: lldb/trunk/include/lldb/Target/DynamicLoader.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Target/DynamicLoader.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Target/DynamicLoader.h (original)
> +++ lldb/trunk/include/lldb/Target/DynamicLoader.h Wed May 15 02:15:13 2019
> @@ -22,23 +22,11 @@
> #include <stdint.h>
> namespace lldb_private {
> class ModuleList;
> -}
> -namespace lldb_private {
> class Process;
> -}
> -namespace lldb_private {
> class SectionList;
> -}
> -namespace lldb_private {
> class Symbol;
> -}
> -namespace lldb_private {
> class SymbolContext;
> -}
> -namespace lldb_private {
> class SymbolContextList;
> -}
> -namespace lldb_private {
> class Thread;
> }
>
>
> Modified: lldb/trunk/include/lldb/Utility/Broadcaster.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/Broadcaster.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Utility/Broadcaster.h (original)
> +++ lldb/trunk/include/lldb/Utility/Broadcaster.h Wed May 15 02:15:13 2019
> @@ -26,14 +26,8 @@
>
> namespace lldb_private {
> class Broadcaster;
> -}
> -namespace lldb_private {
> class EventData;
> -}
> -namespace lldb_private {
> class Listener;
> -}
> -namespace lldb_private {
> class Stream;
> }
>
>
> Modified: lldb/trunk/include/lldb/Utility/Connection.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/Connection.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Utility/Connection.h (original)
> +++ lldb/trunk/include/lldb/Utility/Connection.h Wed May 15 02:15:13 2019
> @@ -22,8 +22,6 @@
>
> namespace lldb_private {
> class Status;
> -}
> -namespace lldb_private {
> template <typename Ratio> class Timeout;
> }
>
>
> Modified: lldb/trunk/include/lldb/Utility/DataExtractor.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/DataExtractor.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Utility/DataExtractor.h (original)
> +++ lldb/trunk/include/lldb/Utility/DataExtractor.h Wed May 15 02:15:13 2019
> @@ -21,8 +21,6 @@
>
> namespace lldb_private {
> class Log;
> -}
> -namespace lldb_private {
> class Stream;
> }
> namespace llvm {
>
> Modified: lldb/trunk/include/lldb/Utility/Event.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/Event.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Utility/Event.h (original)
> +++ lldb/trunk/include/lldb/Utility/Event.h Wed May 15 02:15:13 2019
> @@ -27,8 +27,6 @@
>
> namespace lldb_private {
> class Event;
> -}
> -namespace lldb_private {
> class Stream;
> }
>
>
> Modified: lldb/trunk/include/lldb/Utility/JSON.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/JSON.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Utility/JSON.h (original)
> +++ lldb/trunk/include/lldb/Utility/JSON.h Wed May 15 02:15:13 2019
> @@ -21,8 +21,6 @@
>
> namespace lldb_private {
> class Stream;
> -}
> -namespace lldb_private {
>
> class JSONValue {
> public:
>
> Modified: lldb/trunk/include/lldb/Utility/Listener.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/Listener.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Utility/Listener.h (original)
> +++ lldb/trunk/include/lldb/Utility/Listener.h Wed May 15 02:15:13 2019
> @@ -28,8 +28,6 @@
>
> namespace lldb_private {
> class ConstString;
> -}
> -namespace lldb_private {
> class Event;
> }
>
>
> Modified: lldb/trunk/include/lldb/Utility/StringList.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/StringList.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Utility/StringList.h (original)
> +++ lldb/trunk/include/lldb/Utility/StringList.h Wed May 15 02:15:13 2019
> @@ -17,8 +17,6 @@
>
> namespace lldb_private {
> class Log;
> -}
> -namespace lldb_private {
> class Stream;
> }
>
>
> Modified: lldb/trunk/include/lldb/Utility/StructuredData.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/StructuredData.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Utility/StructuredData.h (original)
> +++ lldb/trunk/include/lldb/Utility/StructuredData.h Wed May 15 02:15:13 2019
> @@ -28,8 +28,6 @@
>
> namespace lldb_private {
> class Status;
> -}
> -namespace lldb_private {
> class Stream;
> }
>
>
> Modified: lldb/trunk/include/lldb/Utility/UserID.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/UserID.h?rev=360757&r1=360756&r2=360757&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Utility/UserID.h (original)
> +++ lldb/trunk/include/lldb/Utility/UserID.h Wed May 15 02:15:13 2019
> @@ -11,11 +11,9 @@
>
> #include "lldb/lldb-defines.h"
> #include "lldb/lldb-types.h"
> -namespace lldb_private {
> -class Stream;
> -}
>
> namespace lldb_private {
> +class Stream;
>
> /// \class UserID UserID.h "lldb/Core/UserID.h"
> /// A mix in class that contains a generic user ID.
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
More information about the lldb-dev
mailing list