[lldb-dev] [Bug 22232] Conditional breakpoint test skipped for Windows

[Ismail Bennani via lldb-dev]

Thanks!

I’ll remove these annotations from the test and submit a patch. 

Ismail

> On Aug 20, 2019, at 2:11 PM, Stella Stamenova <stilis at microsoft.com> wrote:
> 
> It looks like the tests are indeed passing on Windows.
> 
> Thanks,
> -Stella
> 
> -----Original Message-----
> From: lldb-dev <lldb-dev-bounces at lists.llvm.org> On Behalf Of Ismail Bennani via lldb-dev
> Sent: Tuesday, August 20, 2019 11:50 AM
> To: lldb-dev at lists.llvm.org
> Subject: [lldb-dev] [Bug 22232] Conditional breakpoint test skipped for Windows
> 
> Hi,
> 
> While looking at the LLDB test suite, I noticed that the test for conditional breakpoints (TestBreakpointConditions.py) is skipped on Windows.
> 
> The test has an annotation `skipIfWindows` with a comment:
> `# Requires EE to support COFF on Windows (https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fllvm.org%2Fpr22232&data=02%7C01%7CSTILIS%40microsoft.com%7C19421d8b4f9e4a84c1c308d7259f37e3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637019238092234576&sdata=niijsRJS%2ByKyoQ4nC8VI%2FyvGkDY6tcBVEas50142sFI%3D&reserved=0)`
> 
> This bug was reported in 2015 and since then, I assume Windows gained support for expression evaluation. Can someone with a windows machine run this test without the annotation to see if this bug haven’t been fixed already.
> 
> Thanks.
> 
> Ismail
> 
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at lists.llvm.org
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.llvm.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Flldb-dev&data=02%7C01%7CSTILIS%40microsoft.com%7C19421d8b4f9e4a84c1c308d7259f37e3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637019238092234576&sdata=I86gaP%2Bj26JuxwDiP3Tf9h0YK3BlwfhUBXslE2vr7yk%3D&reserved=0