[lldb-dev] [Bug 36630] New: LLDB SB API headers not installed anymore since r309021

[via lldb-dev]

https://bugs.llvm.org/show_bug.cgi?id=36630

            Bug ID: 36630
           Summary: LLDB SB API headers not installed anymore since
                    r309021
           Product: lldb
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P
         Component: All Bugs
          Assignee: lldb-dev at lists.llvm.org
          Reporter: tschelle at redhat.com
                CC: llvm-bugs at lists.llvm.org

Since r309021 the LLDB SB API headers (e.g /usr/include/lldb/API/LLDB.h) are
not installed anymore. Previously they were installed by default.

Looking at the commit that introduced the regression it seems this is coming
from some accidentally committed changes (at least the commit message doesn't
mention anything about the excludes).

The change landed a couple of days after 5.0 was branched so this affects the
6.0 release.

commit 10e79c4459e0a6002edf2fea14432c293c5d509f
Author: Chris Bieneman <beanz at apple.com>
Date:   Tue Jul 25 20:29:45 2017 +0000

    [CMake] Cleanup unnecessary definition

    This is only used in one file, and we already set it correctly on that
file, so we don't need to set this everywhere.   

    git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@309021
91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/cmake/modules/LLDBConfig.cmake b/cmake/modules/LLDBConfig.cmake
index 726552675..71820c965 100644
--- a/cmake/modules/LLDBConfig.cmake
+++ b/cmake/modules/LLDBConfig.cmake
@@ -22,10 +22,6 @@ elseif(IOS)
   set(LLDB_DEFAULT_DISABLE_PYTHON 1)
 endif()

-if(IOS)
-  add_definitions(-DNO_XPC_SERVICES)
-endif()
-
 set(LLDB_DISABLE_PYTHON ${LLDB_DEFAULT_DISABLE_PYTHON} CACHE BOOL
   "Disables the Python scripting integration.")
 set(LLDB_DISABLE_CURSES ${LLDB_DEFAULT_DISABLE_CURSES} CACHE BOOL
@@ -282,6 +278,8 @@ if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
     PATTERN ".svn" EXCLUDE
     PATTERN ".cmake" EXCLUDE
     PATTERN "Config.h" EXCLUDE
+    PATTERN "lldb-*.h" EXCLUDE
+    PATTERN "API/*.h" EXCLUDE
     )

   install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/include/
@@ -291,6 +289,8 @@ if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
     PATTERN "*.h"
     PATTERN ".svn" EXCLUDE
     PATTERN ".cmake" EXCLUDE
+    PATTERN "lldb-*.h" EXCLUDE
+    PATTERN "API/*.h" EXCLUDE
     )
 endif()

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20180307/98ef5469/attachment.html>