[lldb-dev] how do i submit my patch for 'Support demangling for D symbols via dlopen'

Jim Ingham via lldb-dev lldb-dev at lists.llvm.org
Tue Feb 27 09:25:34 PST 2018


I only briefly scanned the patch, but I'm not sure treating D as another mangling variant of C++ is the best model - I think it will be easier if we gather all the separate language features up in the individual languages.  You might have a look at the swift-enabled lldb (https://github.com/apple/swift-lldb/) to see how it is handled there.  That's a little weak because we iterate over supported languages by hand.  When there were a few that wasn't an issue, but as we pick up more languages, we should introduce a "do over supported languages" feature which would clean up the logic there.

Jim


> On Feb 26, 2018, at 9:01 PM, Timothee Cour via lldb-dev <lldb-dev at lists.llvm.org> wrote:
> 
> https://github.com/llvm-mirror/lldb/pull/3
> 
> it would be *really* nice if llvm or lldb accepted industry standard
> github PR's, at least as an option. Would make contributing so much
> easier for outsiders
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev



More information about the lldb-dev mailing list