[lldb-dev] [cfe-dev] ASTImporter patches and improvements, please help

[Davide Italiano via lldb-dev]

On Thu, Dec 6, 2018 at 6:39 AM Gábor Márton <martongabesz at gmail.com> wrote:
>
> Hi Davide,
>
> Thank you for your email.
>
> > In particular, what's the error you get when lldb fails immediately running the tests?
> > Also, have you checked libcxx and libcxx-abi in your build? We might
> > consider making that a mandatory dependency for the Cmake build.
>
> Finally I could run the test suite ("ninja check-lldb) on our macOS without errors. Here are my findings:
> 1) "sudo /usr/sbin/DevToolsSecurity --enable" is a must.
> 2) I indeed did not checked out libcxx. (libcxx-abi was not needed to have a successful run). Would be great to make that a mandatory dependency.
> 3) Besides that I recognized that "ninja check-lldb" target does not build all it's dependencies. E.g. lldb-server tests failed until I executed "ninja debugserver" before "ninja check-lldb". I am not sure, but I think "ninja obj2yaml" and "ninja llvm-pdbutil" are also prerequisites (and these targets seem not to be built by a simple "ninja" command).
>

Any chance you can submit fixes for this? Or, if you can't just open a
PR and I'll take a look.

--
Davide