[lldb-dev] PDB symbol reader supports C++ only?

[Vadim Chugunov via lldb-dev]

These two changes ([1]
<https://github.com/vadimcn/llvm/commit/a8e52b43f4ca43594987ad900277bed7c005461b>
[2]
<https://github.com/vadimcn/lldb/commit/77d54fcbcb82b0b94bcfb238387b055489f3632e>)
appear to be sufficient to enable debugging of Rust binaries with pdb debug
info (make sure that msdia140.dll is somewhere lldb can find it).
At a cursory glance, I did not observe any ill effects of disabling that
language check, so I'm still not sure whether it was truly necessary, or
more of "Let's disable code paths we did not test".

As for allocating a language code for Rust, does Microsoft even have a
procedure for this?   In any case, looks like D folks had already staked out
<https://github.com/llvm-mirror/llvm/blob/d7e8f44ac5abf9599b718cf1438ffbe8adee5db9/include/llvm/DebugInfo/CodeView/CodeView.h#L165>
0x44 for themselves.   I suggest we claim 0x27  :-)

On Mon, Aug 27, 2018 at 6:32 AM Tom Tromey <ttromey at mozilla.com> wrote:

> >>>>> "Vadim" == Vadim Chugunov via lldb-dev <lldb-dev at lists.llvm.org>
> writes:
>
> Vadim> Would you mind going into a bit more detail on what sort of
> Vadim> problems an unknown language could cause?  I'd like to understand
> Vadim> the issue before jumping in to fix anything.  AFAIK, in the case
> Vadim> of DWARF symbols, debug info for unknown languages is still used,
> Vadim> so it wouldn't be the first for LLDB...
>
> LLDB checks for DW_LANG_Rust and uses the C++ plugin in this case.
>
> The Rust lldb (
> https://github.com/rust-lang-nursery/lldb/commits/rust-release-70)
> removes this.
>
> If you get something working, let me know.  I'd like to incorporate it
> into the Rust lldb.
>
> Tom
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20180827/58945058/attachment.html>