[lldb-dev] Prologue instructions having line information

[Jim Ingham via lldb-dev]

This is only tangential, but it is a known bug that when we stop on a line that starts an inlined block we don't pretend we're in the outer function first, so the user can "step-in" to the inlined function.  This is particularly notable when you have several nested levels of inlining starting at the same address, we say the naive thing - that we're in the innermost function, rather than setting up a set of fake step-in's that mirror the inline nesting.  If somebody wants to take a whack at fixing that it would be great.  Shouldn't be too hard.  We need to do other kinds of fakery as well, for instance if you have three levels of nested inlining and you set a breakpoint by specifying the middle function, then when you hit that breakpoint we should pretend we've just stepped into the middle function.

We handle these fictions with straight-line stepping when it encounters inlining pretty much okay.  But when we're just running to an address (and apparently when pushing past the prologue) we're not telling the right story.

Jim

> On Sep 14, 2017, at 3:20 AM, Tamas Berghammer via lldb-dev <lldb-dev at lists.llvm.org> wrote:
> 
> Hi Carlos,
> 
> Thank your for looking into the LLDB failure. I looked into it briefly and the issue is that we have have 2 function f and g where g is inlined into f as the first call and this causes the first non-prologue line entry of f to be inside the address range of g what means that when we step info f from outside we will end up inside g instead. Previously the first line entry for f matched with the start address of the inlined copy of g where LLDB was able to handle the stepping properly.
> 
> For the concrete example you should compile https://github.com/llvm-mirror/lldb/blob/26fea9dbbeb3020791cdbc46fbf3cc9d7685d7fd/packages/Python/lldbsuite/test/functionalities/inline-stepping/calling.cpp with "/mnt/ssd/ll/git/build/host-release/bin/clang-5.0 -std=c++11 -g -O0 -fno-builtin -m32 --driver-mode=g++ calling.cpp" and then observe that caller_trivial_2 have a DW_AT_low_pc = 0x8048790 and the inlined inline_trivial_1 inside it have a DW_AT_low_pc = 0x8048793 but the first line entry after "Set prologue_end to true" is at 0x8048796 while previously it was at 0x8048793.
> 
> Tamas
> 
> On Thu, Sep 14, 2017 at 9:59 AM Carlos Alberto Enciso via lldb-dev <lldb-dev at lists.llvm.org> wrote:
> Hi,
> 
> I have been working on a compiler issue, where instructions associated to the function prolog are assigned line information, causing the debugger to show incorrectly the beginning of the function body.
> 
> For a full description, please see:
> 
> https://reviews.llvm.org/D37625
> https://reviews.llvm.org/rL313047
> 
> The submitted patch caused some LLDB tests to fail. I have attached the log failure.
> 
> I have no knowledge about the test framework used by LLDB.
> 
> What is the best way to proceed in this case?
> 
> Thanks very much for your feedback.
> 
> Carlos Enciso
> 
> 
> 
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev