[lldb-dev] check-lldb will start using in-tree clang by default

[Pavel Labath via lldb-dev]

Ship it.

On 27 October 2017 at 13:56, Davide Italiano <dccitaliano at gmail.com> wrote:
> Take 2 (it can't be in the top-level CMakeList because the check-lldb
> target is declared elsewhere).
>
> $ git diff HEAD
> diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
> index d5d71d1..958f9f3 100644
> --- a/test/CMakeLists.txt
> +++ b/test/CMakeLists.txt
> @@ -109,6 +109,12 @@ add_python_test_target(check-lldb
>    "Testing LLDB (parallel execution, with a separate subprocess per test)"
>    )
>
> +# If we're building with an in-tree clang, then list clang as a dependency
> +# to run tests.
> +if (TARGET clang)
> +  add_dependencies(check-lldb clang)
> +endif()
> +
>  add_custom_target(lldb-test-depends DEPENDS ${LLDB_TEST_DEPENDS})
>  # This will add LLDB's test dependencies to the depenednecies for check-all and
>  # include them in the test-depends target.
>
> On Fri, Oct 27, 2017 at 1:48 PM, Pavel Labath <labath at google.com> wrote:
>> On 27 October 2017 at 13:28, Zachary Turner <zturner at google.com> wrote:
>>> Maybe make it a dependency of the `check-lldb` target instead of the `lldb`
>>> target?
>>>
>>
>> +1