[lldb-dev] purpose of ProcessGDBRemote::m_flags

[Tatyana Krasnukha via lldb-dev]

Sorry, I was unclear – I mean existing recently added plugin “Architecture”. And “dynamic” configuration is not necessary retrieved from gdb-server.

From: Greg Clayton [mailto:clayborg at gmail.com]
Sent: Friday, 3 November, 2017 9:37 PM
To: Tatyana Krasnukha <Tatyana.Krasnukha at synopsys.com>
Cc: lldb-dev at lists.llvm.org
Subject: Re: [lldb-dev] purpose of ProcessGDBRemote::m_flags

If this isn't used, then this should be removed. Anything dynamic settings that are retrieved need to be abstracted into this class. There isn't a need for an extra plug-in as ProcessGDBRemote handles all variants of GDB remote servers and it should encapsulate all that is needed to use any GDB server.

On Nov 3, 2017, at 7:27 AM, Tatyana Krasnukha via lldb-dev <lldb-dev at lists.llvm.org<mailto:lldb-dev at lists.llvm.org>> wrote:

Hello,

I have questions about ProcessGDBRemote::m_flags member. Seems like it is never used. What is the purpose of it and what is the reason to do accessors protected, even constant getter? And other question: isn’t it better to move this member to new plugin Architecture to be able to store dynamic architecture features (read from target’s configuration registers, for example)?
_______________________________________________
lldb-dev mailing list
lldb-dev at lists.llvm.org<mailto:lldb-dev at lists.llvm.org>
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev<https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_lldb-2Ddev&d=DwMFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=yfnu24japkhNGh-WqJObHXmH3mINtC_2FO828lrNpM0&m=TPGuCrskMMaB7m6l1CDkxftg4_0EFERP7gNT0_znGHc&s=zE0tNmv1hqZKYmVJ27YFB_VSv_0ZDpercK61ZVsfUKc&e=>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20171103/8029e5d0/attachment.html>