[lldb-dev] Prebuilt binary for Windows

[Zachary Turner via lldb-dev]

I will commit it, in the meantime can you request commit access so that any
future patches you can commit?

On Wed, Jan 4, 2017 at 1:54 PM Vadim Chugunov <vadimcn at gmail.com> wrote:

> Thanks!
>
> Would anyone be so kind to commit that?
>
> On Wed, Jan 4, 2017 at 11:47 AM, Zachary Turner <zturner at google.com>
> wrote:
>
> Sorry, a combination of national holidays and extended vacations happened
> and this fell off my radar.  lgtm
>
> On Wed, Jan 4, 2017 at 11:46 AM Vadim Chugunov <vadimcn at gmail.com> wrote:
>
> Zachary,
> Can you please take a look at that change? (
> https://reviews.llvm.org/D27476)
>
> It'll be sad if another snapshot build gets published with broken lldb. :(
>
>
> On Tue, Dec 6, 2016 at 11:54 AM, Vadim Chugunov <vadimcn at gmail.com> wrote:
>
> This seems to work: https://reviews.llvm.org/D27476
>
> On Mon, Dec 5, 2016 at 12:04 PM, Hans Wennborg <hans at chromium.org> wrote:
>
> The only thing needed to build the installer should be having NSIS
> installed and building the "package" target generated by CMake. The
> other prerequisites are mostly for building the visual studio
> clang-format plugin.
>
> Having said that, you don't even have to build the installer to see
> what goes in it. Just building the "install" target generated by CMake
> will install the same set of files.
>
> I'm not sure how LLDB's cmake files are organized, but in the end
> what's required is invoking the install() command:
> https://cmake.org/cmake/help/v3.0/command/install.html  In LLVM, this
> is done automatically by macros such as add_llvm_executale, etc.
>
> On Mon, Dec 5, 2016 at 11:56 AM, Vadim Chugunov <vadimcn at gmail.com> wrote:
> > Hi Hans,
> >
> > I'd love to help, but I don't have half the tools that
> > build_llvm_package.bat requires installed on my machine.  My setup is to
> > build llvm with msbuild.   Is it possible to build the installer this way
> > too?
> >
> > Can you point me to the specific CMake source that determines what's
> > included in the package?   At a glance, everything from
> > %LLVM%/lib/site-packages is missing.
> >
> > Vadim
> >
> > On Mon, Dec 5, 2016 at 10:41 AM, Hans Wennborg <hans at chromium.org>
> wrote:
> >>
> >> Is anyone working on this?
> >>
> >> I'm happy to include LLDB in the installer, but I'm really not the
> >> best person to be debugging it.
> >>
> >> If more files need to be included in the install, that's configured in
> >> the CMake files (what's installed by the 'install' build target is
> >> also what ends up going into the installer). If it needs more build
> >> flags, patches to build_llvm_package.bat are welsome.
> >
> >
> >
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20170105/a8c4ee66/attachment-0001.html>