[lldb-dev] Command history query

[Zachary Turner via lldb-dev]

Scratch that, looks like you already fixed this.

On Wed, Apr 19, 2017 at 4:50 PM Zachary Turner <zturner at google.com> wrote:

> I'll take a look
>
> On Wed, Apr 19, 2017 at 10:33 AM Jim Ingham via lldb-dev <
> lldb-dev at lists.llvm.org> wrote:
>
>> No, this was an inadvertent side effect of rewriting the command parser
>> to use llvm's StringRef's.  Please file a bug (or submit a patch!)
>>
>> Jim
>>
>> > On Apr 18, 2017, at 10:49 PM, via lldb-dev <lldb-dev at lists.llvm.org>
>> wrote:
>> >
>> > Hello,
>> >
>> > The query to repeat a command from history used to be !<command_number>
>> but it looks like that doesnt work anymore. It seems to require a space in
>> between (! <command_number>).
>> >
>> > Was this change made intentionally ?
>> >
>> > Code snippet from CommandHistory.cpp:
>> >
>> > input_str = input_str.drop_front(); --> this drops the !
>> >
>> >  size_t idx = 0;
>> >  if (input_str.front() == '-') {
>> >    if (input_str.drop_front(2).getAsInteger(0, idx))
>> >      return llvm::None;
>> >    if (idx >= m_history.size())
>> >      return llvm::None;
>> >    idx = m_history.size() - idx;
>> >  } else {
>> >    if (input_str.drop_front().getAsInteger(0, idx)) --> we drop here
>> again
>> >      return llvm::None;
>> >    if (idx >= m_history.size())
>> >      return llvm::None;
>> > }
>> >
>> > Thanks,
>> > Sudharsan Veeravalli
>> > _______________________________________________
>> > lldb-dev mailing list
>> > lldb-dev at lists.llvm.org
>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>>
>> _______________________________________________
>> lldb-dev mailing list
>> lldb-dev at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20170419/19a12700/attachment.html>