[lldb-dev] RFC: Break/Watchpoint refactor

[Jim Ingham via lldb-dev]

> On Sep 27, 2016, at 2:55 PM, Daniel Austin Noland <daniel.noland at gmail.com> wrote:
> 
>>> The main problem here is that Watchpoints & Breakpoints should share the Options class, and most of the StopInfo DoOnRemoval.  I don’t think you’ll need to write a lot of new code to do this, it’s mostly ripping out the WatchpointOptions, using BreakpointOptions instead adapting as necessary.  Ditto for the StopInfo{Watchpoint,Breakpoint}.
>> So you would avoid inheritance and just make Watchpoint and Breakpoint take the same StoppointOptions class?
>>> 
> 

That is the way I would approach it.  The other half of this is StopInfoBreakpoint vrs. StopInfoWatchpoint classes.  These aren’t going to be exactly equivalent so you will probably have to find some way express what needs to be different, but those differences should be pretty small.  The Breakpoint side of this works pretty well, so I’d start from there.

Jim

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20160927/7d1ae330/attachment.html>