[lldb-dev] [Bug 30492] New: On Linux, lldb lit tests fail

[via lldb-dev]

https://llvm.org/bugs/show_bug.cgi?id=30492

            Bug ID: 30492
           Summary: On Linux, lldb lit tests fail
           Product: lldb
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P
         Component: All Bugs
          Assignee: lldb-dev at lists.llvm.org
          Reporter: hfinkel at anl.gov
                CC: llvm-bugs at lists.llvm.org
    Classification: Unclassified

I needed the following changes to make the lldb lit tests work on my Linux
build system:

diff --git a/lit/Expr/TestCallStopAndContinue.test
b/lit/Expr/TestCallStopAndContinue.test
index f518f3d..263fa2a 100644
--- a/lit/Expr/TestCallStopAndContinue.test
+++ b/lit/Expr/TestCallStopAndContinue.test
@@ -9,4 +9,4 @@ breakpoint set --file call-function.cpp --line 14
 expression -i false -- returnsFive()
 # CHECK: Execution was interrupted, reason: breakpoint
 # CHECK: stop reason = User Expression thread plan
-# CHECK: Completed expression: (Five) $0 = (number = 5 {{.*}}, name = "five")
+# CHECK: Completed expression: (Five) $0 = (number = 5{{.*}}, name = "five")
diff --git a/lit/lit.cfg b/lit/lit.cfg
index e18719b..fe00344 100644
--- a/lit/lit.cfg
+++ b/lit/lit.cfg
@@ -140,7 +140,9 @@ config.substitutions.append(('%cc', config.cc))
 config.substitutions.append(('%cxx', config.cxx))

 config.substitutions.append(('%lldb', lldb))
-config.substitutions.append(('%debugserver', debugserver))
+
+if debugserver is not None:
+  config.substitutions.append(('%debugserver', debugserver))

 for pattern in [r"\bFileCheck\b",
                 r"\| \bnot\b"]:


For the second change, the problem is that, on Linux, there is no "debugserver"
process, and the RUN-line substitution will fail if you try to substitute
'%debugserver' with None. For the first change, I don't know why there would be
a space after the 5 on any system.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20160922/6f254f42/attachment.html>