[lldb-dev] LLDB REFORMATTING IN PROGRESS

[Ilia K via lldb-dev]

But what about SVN users? :)
Okay, I know format can be applied for modified fragments only. But why did
we leave some places unformatted? I thought "clang-format -i `find include
source tools -name '*.[cpp|h]'`" ends with empty diff.

On Thu, Sep 8, 2016 at 10:19 AM, Zachary Turner <zturner at google.com> wrote:

> In order to clang-format only the diff, you should use the "git
> clang-format" extension command. Search for git-clang-format (yes, that one
> has an extra dash), and there should be instructions inside
> On Thu, Sep 8, 2016 at 12:16 AM Ilia K <ki.stfu at gmail.com> wrote:
>
>> Hi!
>>
>> clang-formatting of my patch changed the style outside the patch (diff:
>> https://reviews.llvm.org/D24331?vs=70653&id=70654). Am I doing something
>> wrong?
>>
>> On Wed, Sep 7, 2016 at 1:06 PM, Pavel Labath via lldb-dev <
>> lldb-dev at lists.llvm.org> wrote:
>>
>>> Windows unit tests passing now. All clear.
>>>
>>> On 7 September 2016 at 09:54, Pavel Labath <labath at google.com> wrote:
>>> > I am still seeing errors when building windows unittests. I'll have a
>>> > change for fixing that soon. Apart from that everything else looks
>>> > good on our side. I'll send an all clear once the unit tests get green
>>> > on windows.
>>> >
>>> > pl
>>> >
>>> > On 6 September 2016 at 23:26, Zachary Turner via lldb-dev
>>> > <lldb-dev at lists.llvm.org> wrote:
>>> >> I think Windows is good.
>>> >>
>>> >> On Tue, Sep 6, 2016 at 3:10 PM Zachary Turner <zturner at google.com>
>>> wrote:
>>> >>>
>>> >>> Everything compiles on Windows now but all the tests are failing with
>>> >>> ERROR.  I'm looking into this now.
>>> >>>
>>> >>> On Tue, Sep 6, 2016 at 2:26 PM Ed Maste via lldb-dev
>>> >>> <lldb-dev at lists.llvm.org> wrote:
>>> >>>>
>>> >>>> On 6 September 2016 at 17:17, Kate Stone via lldb-dev
>>> >>>> <lldb-dev at lists.llvm.org> wrote:
>>> >>>> > The storm of commit messages might be a subtle clue, but here it
>>> is
>>> >>>> > officially: the reformatting is complete and I’ve verified that no
>>> >>>> > tests
>>> >>>> > regressed locally in our macOS suite.  Please begin any validation
>>> >>>> > process
>>> >>>> > you’ve signed up for on another platform, and if changes are
>>> necessary
>>> >>>> > go
>>> >>>> > ahead and land them individually.
>>> >>>>
>>> >>>> FreeBSD currently fails to build due to header reordering in
>>> >>>> source/Host/freebsd/Host.cpp which I'll sort out shortly.
>>> >>>>
>>> >>>> I'd like to request that we avoid any functional changes other than
>>> >>>> those restoring builds to green, until we get the "all clear" from
>>> >>>> everyone who's signed up to validate other platforms.
>>> >>>>
>>> >>>> -Ed
>>> >>>> _______________________________________________
>>> >>>> lldb-dev mailing list
>>> >>>> lldb-dev at lists.llvm.org
>>> >>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>>> >>
>>> >>
>>> >> _______________________________________________
>>> >> lldb-dev mailing list
>>> >> lldb-dev at lists.llvm.org
>>> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>>> >>
>>> _______________________________________________
>>> lldb-dev mailing list
>>> lldb-dev at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>>>
>>
>>
>>
>> --
>> - Ilia
>>
>


-- 
- Ilia
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20160908/edfb1fbf/attachment.html>