[lldb-dev] something just toasted the test suite on OS X

[Enrico Granata via lldb-dev]

Should be reverted in 258791.

Sent from my iPhone

> On Jan 25, 2016, at 8:54 PM, Zachary Turner <zturner at google.com> wrote:
> 
> sorry, yea I stuck around for a while after that patch waiting for emails, but nothing came through.  Please revert in the meantime, I'll work on a fix tomorrow.
> 
>> On Mon, Jan 25, 2016 at 8:52 PM Todd Fiala via lldb-dev <lldb-dev at lists.llvm.org> wrote:
>> I think I see what happened w/r/t why no emails when out when the build went heavy red.  (Well they went out internally, but not externally).  When I made the change on Friday to improve the workflow for the Green Dragon OS X builder and test output, I switched email over to the builder step, which doesn't know anything about who made which changes.  So it didn't know who to put on the blame list for the broken build.  Drats, I'll have to figure that out.
>> 
>> I'd really prefer to have all those stages happening in one build step to keep it clear what's going on.
>> 
>>> On Mon, Jan 25, 2016 at 8:25 PM, Todd Fiala <todd.fiala at gmail.com> wrote:
>>> Well our whole test suite just stopped running, so yes.
>>> 
>>>> On Mon, Jan 25, 2016 at 6:58 PM, Enrico Granata <egranata at apple.com> wrote:
>>>> 
>>>>> On Jan 25, 2016, at 6:48 PM, Todd Fiala via lldb-dev <lldb-dev at lists.llvm.org> wrote:
>>>>> 
>>>>> Not sure exactly what it is, but all the tests are failing due to some bad assumptions of unicode vs. str on Python 2 vs. 3 if I had to guess.
>>>> 
>>>> Author: zturner
>>>> Date: Mon Jan 25 18:59:42 2016
>>>> New Revision: 258759
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=258759&view=rev
>>>> Log:
>>>> Write the session log file in UTF-8.
>>>> 
>>>> Previously we were writing in the default encoding, which depends
>>>> on the operating system and is not guaranteed to be unicode aware.
>>>> On Python 3, this would lead to a situation where writing unicode
>>>> text to the log file generates an exception.  The fix here is to
>>>> write session logs using the proper encoding, which incidentally
>>>> fixes another test, so xfail is removed from that.
>>>> 
>>>> sounds like a likely culprit from what you’re saying
>>>> 
>>>>> I am not going to be able to look at details on that, but here's a link to the log on the OS X builder:
>>>> 
>>>> Do you want me to revert?
>>>> 
>>>>> http://lab.llvm.org:8080/green/job/lldb_build_test/16166/console
>>>>> 
>>>>> -- 
>>>>> -Todd
>>>>> _______________________________________________
>>>>> lldb-dev mailing list
>>>>> lldb-dev at lists.llvm.org
>>>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>>>> 
>>>> 
>>>> Thanks,
>>>> - Enrico
>>>> 📩 egranata@.com ☎️ 27683
>>> 
>>> 
>>> 
>>> -- 
>>> -Todd
>> 
>> 
>> 
>> -- 
>> -Todd
>> _______________________________________________
>> lldb-dev mailing list
>> lldb-dev at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20160125/9b12e565/attachment.html>