[lldb-dev] [llvm-dev] [cfe-dev] [3.8 Release] We have branched

[Hans Wennborg via lldb-dev]

On Wed, Jan 20, 2016 at 7:32 AM, Renato Golin <renato.golin at linaro.org> wrote:
> Hans, Daniel,
>
> How are things going? It's been 5 days and no word. I'm running the
> tests now, just in case, but would be good to know that no one would
> be committing to the release candidate 1 tree in the mean time.

Did you send this before I sent the rc1 email, or what things are you
referring to? :-)




> On 15 January 2016 at 15:56, Daniel Sanders via llvm-dev
> <llvm-dev at lists.llvm.org> wrote:
>>> -----Original Message-----
>>> From: hwennborg at google.com [mailto:hwennborg at google.com] On Behalf
>>> Of Hans Wennborg
>>> Sent: 15 January 2016 15:52
>>> To: Daniel Sanders
>>> Cc: llvm-dev; lldb-dev at lists.llvm.org; openmp-dev at lists.llvm.org; cfe-
>>> dev at lists.llvm.org
>>> Subject: Re: [cfe-dev] [3.8 Release] We have branched
>>>
>>> Hi Daniel,
>>>
>>> Thanks for trying out the branch :-)
>>>
>>> On Fri, Jan 15, 2016 at 5:30 AM, Daniel Sanders
>>> <Daniel.Sanders at imgtec.com> wrote:
>>> > Hi Hans,
>>> >
>>> > I tried the release branch last night and I'm having problems building it. The
>>> problem is that test-suite is now building as part of the Phase[123] builds
>>> (because this project contains CMakeLists.txt's now) but cmake 3.0.2 (from
>>> Debian Jessie) generates an invalid Makefile.
>>> > The error is:
>>> >         CMakeFiles/test-suite.dir/build.make:112: *** target pattern contains
>>> no '%'.  Stop.
>>> >         CMakeFiles/Makefile2:199: recipe for target 'CMakeFiles/test-
>>> suite.dir/all' failed
>>> > And the referenced line of the generated makefile is:
>>> >         test-suite-stamps/test-suite-force-rebuild: /home/das-local/llvm-
>>> release-3.8/release/branches_release_38/llvm.src/$<TARGET_FILE:clang>
>>> > it looks like cmake isn't fully expanding its generator expressions.
>>> >
>>> > Looking at my logs, it looks like the test-suite used to configure in 3.6.2 but
>>> didn't build as part of test-release.sh and then 3.7.0 stopped since we had
>>> switched to cmake and there was no CMakeLists.txt.
>>> > I've always run the test-suite as a separate step as described in
>>> http://llvm.org/docs/ReleaseProcess.html. Should we stop creating the
>>> projects/test-suite symlink to get back to the behaviour from 3.7.0 or should
>>> we do something else?
>>>
>>> Yes, I made the script stop making the symlink in r257791 and merged
>>> it to the branch. Did that not work for you, or were you at an earlier
>>> revision?
>>>
>>> Thanks,
>>> Hans
>>
>> I'm at r257773 so it looks like I didn't pick up that change. I'll give it another try tonight.