[lldb-dev] [RFC] Delete the "testcases" symlink

[Zachary Turner via lldb-dev]

The reason they were put into the packages directory in the first place is
because this forms a proper python package so that more code can be shared
amongst test cases.  I don't know why the symlink was ever created in the
first place, sounds like that was probably put in place by someone who
thought packages/python/lldbsuite/test was too much to type (hard to argue
with, tbh).  In any case, as long as you can maintain the package structure
so that a testcase can write "from support import fs" then you can
re-arrange stuff however you like.

I also think some people had expressed interest in writing bindings for
other languages, but I haven't heard anything about that in some time, so
until I see more effort on that front a concrete proposal, we don't need to
worry about it.

On Thu, Dec 15, 2016 at 9:38 AM Chris Bieneman via lldb-dev <
lldb-dev at lists.llvm.org> wrote:

> So, I want to delete the testcases symlink from the LLDB tree, and move
> the tests out of the packages directory into tests/testcases.
>
> A few reasons why I want to do this:
> (1) I can't imagine symlinks in SVN is something that works well on
> platforms that don't support symlinks (like Windows)
> (2) It trips up scripts and tools that try to operate on the files without
> calling realpath (while I know I could fix those, it is easier to just fix
> this)
> (3) It seems to me that it is completely unnecessary. In lldbsuite's
> __init__.py we already find the test cases by path from the lldb checkout
> root, so having them live in the python packages just seems odd.
>
> Thoughts?
>
> Is there a reason why they need to live in the packages directory that I'm
> unaware of?
>
> -Chris
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20161215/d3d61802/attachment.html>