[lldb-dev] LLDB Evolution

[Zachary Turner via lldb-dev]

Yea, if you see above, I mentioned that clang-format has a style option
called CommentPragmas, which allows you to specify a regex for comments
that clang-format won't touch.  If you specified CommentPragmas: .* then it
would never touch any comment no matter what.

(Note that I haven't actually tested this or ever used this option in
practice, just see that it's there and claims to be for this use case)

On Thu, Aug 11, 2016 at 10:00 AM Sean Callanan via lldb-dev <
lldb-dev at lists.llvm.org> wrote:

> In fact, the lldbinline tests could be completely broken by
> clang-formatting them.  They treat each //% line as a separate command to
> execute.  If clang-format broke those lines, lldbinline tests would stop
> working.
>
> Sean
>
> > On Aug 11, 2016, at 9:57 AM, Chris Lattner via lldb-dev <
> lldb-dev at lists.llvm.org> wrote:
> >
> >
> >> On Aug 11, 2016, at 7:41 AM, Pavel Labath <labath at google.com> wrote:
> >>
> >> I just committed another  header cleanup commit, which makes lldb
> >> clang-format-immune ( = it still compiles after a full reformat) on
> >> linux. Other OS's are still likely to have some missed dependencies.
> >
> > Nice!
> >
> >> However, when I tried running the test suite I got about 150 failures.
> >> Based on a sample of the errors, it looks like the problem is that
> >> clang format messes up the "// Place breakpoint here" annotations we
> >> use in the tests.
> >> Therefore, I propose to apply the clang-format to the lldb source code
> >> only as a first step. After that, as a second step, we can go through
> >> the tests and fix them up so that the comment markers are where we
> >> expect them to be.
> >
> > Personally, I think that reformatting is most valuable for the debugger
> code itself.  The testsuite following standards seems like a separable
> issue, and much lower priority.
> >
> > -Chris
> > _______________________________________________
> > lldb-dev mailing list
> > lldb-dev at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20160811/de79b9e2/attachment.html>