[lldb-dev] lldb-mi plans

[Ilia K via lldb-dev]

On Fri, Sep 25, 2015 at 2:33 PM, Ilia K <ki.stfu at gmail.com> wrote:

> oops..
> -lldb-dev at cs.uiuc.edu
> +lldb-dev at lists.llvm.org
>
> On Fri, Sep 25, 2015 at 2:30 PM, Hafiz Abid Qadeer <abidh.haq at gmail.com>
> wrote:
>
>> Sounds reasonable to me.
>>
>> On Fri, Sep 25, 2015 at 8:02 AM, Ilia K <ki.stfu at gmail.com> wrote:
>>
>>> Hi guys!
>>>
>>> I found the following things that can be simplified:
>>> 1. Add CMIUtilString(std::string) ctor:
>>> ```
>>> CMIUtilString(std::string().c_str()) -> CMIUtilString(std::string())
>>> ```
>>> Patch: http://reviews.llvm.org/D13158
>>> 2. Rename CMICmnBase::SetErrorDescriptionn to
>>> CMICmnBase::SetErrorDescriptionFormat
>>> 3. Allow to pass unformatted arguments (i.e. format string + tuple of
>>> parameters) to CMICmnBase::SetErrorDescription:
>>> ```
>>> SetErrorDescription(CMIUtilString::Format(MIRSRC(IDS_CMDFACTORY_ERR_INVALID_CMD_NAME),
>>> vMiCmd.c_str()))
>>> ```
>>> and then remove CMICmnBase::SetErrorDescriptionFormat.
>>> 4. Allow to pass unformatted arguments to CMICmdBase::SetError:
>>> ```
>>> SetError(CMIUtilString::Format(MIRSRC(IDS_CMD_ERR_OPTION_NOT_FOUND),
>>> m_cmdData.strMiCmd.c_str(), m_constStrArgThread.c_str()));
>>> ```
>>>
>>> Thoughts?
>>>
>>> --
>>> - Ilia
>>>
>>
>>
>
>
> --
> - Ilia
>



-- 
- Ilia
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20150925/963abac6/attachment.html>