[lldb-dev] Help with MSVC build issues

[Eugene Zelenko via lldb-dev]

On Thu, Oct 22, 2015 at 11:15 AM, Zachary Turner <zturner at google.com> wrote:
> For the disassembler patch, the problem is you've defaulted the destructor
> but you've got a unique_ptr to a forward declared class.  MSVC is actually
> correct in failing to compile this, and I'm not sure why other compilers are
> accepting it.  My guess is something to do with the order of includes from
> the cpp file.
>
> To fix this you need to remove the `default` keyword from the destructor and
> provide an empty implementation of the destructor in DisassemblerLLVMC.cpp
>
> This problem occurs in other places too.  In OperatingSystemGo.h the same
> problem exists with DynamicRegisterInfo.  That's the one causing the
> operating system patch to fail.
>
> What compiler are you testing this with?  This should fail under clang as
> well, I'm surprised it doesn't.  Are you using GCC by chance?
>
> In any case, you'll need to fix all the occurrences of having a defaulted
> destructor in a class with a std::unique_ptr of an incomplete type.

I think including missing file will be better solution.

I use trunk (~ week old) Clang.

Eugene.