[lldb-dev] Help with MSVC build issues

[Zachary Turner via lldb-dev]

I'm taking a look now. In the future please revert changes that break a
buildbot.  If you think you might know what the fix is (i.e. you guess that
including a header will fix it), then you can just check it in as a test.
If after a few attempts you still can't figure it out, then revert the
change out again.

But definitely please don't leave broken changes in.  For example, the MSVC
buildbot is now failing due to changes in LLVM.  The reason is because it
broke last night due to some unrelated changes which weren't reverted, and
subsequent breaks did not result in an email to other people so they didn't
know.  We need to avoid this situation, so the bot has to stay green.

anyway I'm working on fixing it now

On Thu, Oct 22, 2015 at 9:28 AM Eugene Zelenko via lldb-dev <
lldb-dev at lists.llvm.org> wrote:

> Hi!
>
> I broke couple of times MSVC builds when committed minor code
> cleanups. Looks like problem occurred because of changed order of
> headers.
>
> I could not investigated problems myself, because I don't have access to
> MSVC.
>
> Changes in question:
>
> r250872:
>
> source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp
> source/Plugins/Disassembler/llvm/DisassemblerLLVMC.h
>
> r250925:
>
> source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp
> source/Plugins/OperatingSystem/Go/OperatingSystemGo.h
>
> Eugene.
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20151022/0381ecde/attachment.html>