[lldb-dev] Process::SyncIOHandler(), everyone please try out the following patch

[Pavel Labath]

Thanks for the report.

On 20 May 2015 at 23:04, Ryan Brown <ribrdb at google.com> wrote:
> I just noticed a couple tsan warning when using your patch in an interactive
> session. It's not obvious to me if these are real issues or not:
>
> ==================
> WARNING: ThreadSanitizer: data race (pid=42951)
>   Write of size 1 at 0x7d44000046b0 by thread T6:
>     #0 lldb_private::IOHandler::SetIsDone(bool)
> ../tools/lldb/include/lldb/Core/IOHandler.h:95
> (liblldb.so.3.7+0x0000019d0861)
This looks fairly benign, as both are setting it to false, but I guess
it's still technically UBD. I'll try to get rid of that.


> ==================
> WARNING: ThreadSanitizer: data race (pid=42951)
>   Read of size 8 at 0x7da0000080c0 by thread T2 (mutexes: write M171):
>     #0 write <null>:0 (lldb-3.7.0+0x0000000649c0)
>     #1 operator() ../tools/lldb/source/Host/posix/PipePosix.cpp:416
> (liblldb.so.3.7+0x000001982201)

This looks more serious as we could be trying to write to a pipe
before the pipe is created. I'll take a look at that.