[lldb-dev] raw c strings in lldb

[Zachary Turner]

My impression is that the current state of LLDB with Unicode filenames and
paths is pretty abysmal.  I assumed that nothing would work at all in the
current codebase.  Are you saying that you are using LLDB to support
Unicode today, or just that -- as a general matter - supporting Unicode
strings is something we should do someday, so we shouldn't make our future
work more difficult?

On Tue, Feb 24, 2015 at 9:34 PM <dawn at burble.org> wrote:

> Please keep in mind that we need to be able to handle Unicode strings
> and filenames, so please don't do anything that makes the handling of
> Unicode strings worse.  I.e. please don't add any (more) code which
> assumes a string is NULL-terminated.
>
> Thanks,
> -Dawn
>
> On Wed, Feb 11, 2015 at 07:52:26PM +0000, Zachary Turner wrote:
> > On Wed Feb 11 2015 at 11:13:22 AM Greg Clayton <gclayton at apple.com>
> wrote:
> >
> > >
> > > > Operations:
> > > > strcpy, strncpy, etc         // Use member functions of SmallString /
> > > StringRef
> > > > sprintf, snprintf, etc       // Use llvm::raw_ostream
> > >
> > > We have StringStream, people should be using that. raw_ostream doesn't
> > > support all printf style formats. So all sprintf  and snprintf function
> > > calls should switch to using lldb_private::StreamString.
> > >
> >
> > What if llvm::SmallString<> had Format methods that delegated to snprintf
> > etc?  Then everything would just work, and it would integrate nicely with
> > the rest of my suggested points such as converting things to StringRef,
> > SmallVectorImpl, etc.
>
> > _______________________________________________
> > lldb-dev mailing list
> > lldb-dev at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20150225/ac1b29e5/attachment.html>