[lldb-dev] Xcode 6 Merge: Line Editing

Kate Stone katherine_stone at apple.com
Thu Oct 16 17:45:57 PDT 2014


Life, work, illness, and a surprise last-minute merge with colliding changes slowed the process down, but as promised I’ve posted the proposed change:

http://reviews.llvm.org/D5835 <http://reviews.llvm.org/D5835>

Kate Stone k8stone at apple.com <mailto:k8stone at apple.com>
 Xcode Runtime Analysis Tools

> On Oct 6, 2014, at 8:55 AM, Todd Fiala <tfiala at google.com> wrote:
> 
> Great, thanks Kate!
> 
> On Sun, Oct 5, 2014 at 9:26 AM, Kate Stone <katherine_stone at apple.com <mailto:katherine_stone at apple.com>> wrote:
> Will do.  It turns out they're somewhat intertwined with some of Greg's changes, so we'll sort them out first thing next week and post a patch.
> 
> Kate Stone k8stone at apple.com <mailto:k8stone at apple.com>
>  Xcode Runtime Analysis Tools
> 
> On Oct 3, 2014, at 8:43 PM, Todd Fiala <todd.fiala at gmail.com <mailto:todd.fiala at gmail.com>> wrote:
> 
>> Hey Kate,
>> 
>> Might you be able to put up the patches (say on reviews.llvm.org <http://reviews.llvm.org/>) a bit ahead of time and we can maybe have a chance to address any issues on the Linux side before it goes into top of tree?  Or if reviews.llvm.org <http://reviews.llvm.org/> is inconvenient, we could either do an svn branch, or I'd be happy to clone from a github (or create a github branch you could patch into at github.com/tfiala/lldb <http://github.com/tfiala/lldb>).  Not a big deal either way, but we've hit a number of hiccups on the non-Apple side with the IOHandler work in the past, and this might speed up our ability to address any issues ahead of time.
>> 
>> In any event, thanks for the heads up!
>> 
>> -Todd
>> 
>> On Fri, Oct 3, 2014 at 2:17 PM, Kate Stone <katherine_stone at apple.com <mailto:katherine_stone at apple.com>> wrote:
>> If you’ve used the Xcode 6 Swift REPL you may have noticed a number of changes to the way we handle line editing, particularly for text spanning multiple lines.  I intend to merge back the relevant line editing changes in the next few days and wanted to provide some advance warning that this is coming.  This completely replaces editline.h/cpp and makes non-trivial changes to IOHandler.h/cpp.  There are also minor changes to the command interpreter.  From the original commit log:
>> 
>>     Complete rewrite of interactive editing support for single- and multi-line input.
>>     
>>     Improvements include:
>>     * Use of libedit's wide character support, which is imperfect but a distinct improvement over ASCII-only
>>     * Use of "faint” colorization for line prompts
>>     * Breaking lines and insert new lines in the middle of a batch by simply pressing return
>>     * Joining lines with forward and backward character deletion
>>     * Detection of paste to suppress automatic formatting and statement completion tests
>>     * Correctly reformatting when lines grow or shrink to occupy different numbers of rows
>>     * Saving multi-line history, and correctly preserving the "tip" of history during editing
>>     * Displaying visible ^C and ^D indications when interrupting input or sending EOF
>>     * VI support for multi-line editing
>>     * General correctness and reliability improvements
>> 
>> The most obvious caveat here is that while these changes have been exercised on OS X, it’s certainly possible that we’ll see issues crop up on other platforms as a result.
>> 
>> Kate Stone k8stone at apple.com <mailto:k8stone at apple.com>
>>  Xcode Runtime Analysis Tools
>> 
>> 
>> _______________________________________________
>> lldb-dev mailing list
>> lldb-dev at cs.uiuc.edu <mailto:lldb-dev at cs.uiuc.edu>
>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev <http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev>
>> 
>> 
>> 
>> 
>> -- 
>> -Todd
>> _______________________________________________
>> lldb-dev mailing list
>> lldb-dev at cs.uiuc.edu <mailto:lldb-dev at cs.uiuc.edu>
>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev <http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev>
> 
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at cs.uiuc.edu <mailto:lldb-dev at cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev <http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev>
> 
> 
> 
> 
> -- 
> Todd Fiala |	 Software Engineer |	 tfiala at google.com <mailto:tfiala at google.com>	
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20141016/fec41071/attachment.html>


More information about the lldb-dev mailing list