[lldb-dev] Referencing rdar bugs in commit messages

Zachary Turner zturner at google.com
Thu Nov 13 11:15:15 PST 2014


>
>
> +1 - the patch seemed trivial and obvious enough that a few words suffice
> to explain it, regardless of radar
>

I agree, and sorry for using your patch to bring the issue up.  It's just
something I've seen off and on through the months.

I probably should have just raised the issue of more descriptive commit
message independently of radar, so my fault on that front.  Like an "even
if there's nothing wrong, that doesn't mean it can't be improved" kind of
thing.

I usually try to write commit messages so that someone who doesn't
understand anything about Windows can still figure out what my patch is
doing.

I was actually under the impression that other LLVM projects weren't
allowed to put rdar numbers in commit messages, but someone explained to me
offline that I was wrong about that, so putting it at the bottom is
probably fine.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20141113/2ffa16c4/attachment.html>


More information about the lldb-dev mailing list