[lldb-dev] [PATCH] Don't calculate whole file crc for ELF core file.

[Todd Fiala]

Piotr,

I just checked this in after reviewing and testing.  It includes the lazy
eval and caching that you added in a separate thread with me.

tfiala at tfiala2:/mnt/ssd/work/svn/lgs/llvm/tools/lldb$ svn commit
Waiting for Emacs...
Sending        source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
Sending        source/Plugins/ObjectFile/ELF/ObjectFileELF.h
Transmitting file data ..
Committed revision 204749.

Thanks for improving that, Piotr!

Sincerely,
Todd Fiala


On Mon, Mar 24, 2014 at 11:10 AM, Piotr Rak <piotr.rak at gmail.com> wrote:

>
>
> 2014-03-24 18:52 GMT+01:00 Ed Maste <emaste at freebsd.org>:
>
> On 23 March 2014 14:28, Piotr Rak <piotr.rak at gmail.com> wrote:
>> >
>> > If I understand correctly the main purpose of UUID's for ObjectFileELF
>> is
>> > aiding gnu_debuglink which is used to locate debug info. The other one
>> is
>> > related to ModuleSpec and ModuleList where it is used for
>> identification.
>> >
>> > First in case of modules doesn't make much sense, it won't be correct,
>> or
>> > have even possibility to work, while second turns out to be useful,
>> anyway.
>>
>> gnu_debuglink uses the CRC to confirm that a standalone debug file
>> (e.g. library.so.debug) matches the binary or library, and needs to be
>> calculated only for those debug files.  In fact, prior to the
>> gnu_debuglink support I think ELF files all ended up with an all-0s
>> UUID.  I think your change is a reasonable first step.
>>
>> -Ed
>>
>
> I was thinking about core files, not modules - no proof reading on my side
> - sorry, and of course you're 100% correct here.
> We already got gnu_debuglink crc from binary, and calculated value from
> core file makes no sense for that purpose.
>
> What I was thinking about is that would be nice to have "core matches
> executable" functionality, and I plan to work at it at some point, but it
> is other issue...
>
> Cheers,
> /P
>
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
>
>


-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20140325/36b2ba15/attachment.html>