[lldb-dev] [PATCH] Minor lldb_private::ModuleList fixes

[Piotr Rak]

2014-03-24 20:23 GMT+01:00 Todd Fiala <tfiala at google.com>:

> > For future:
> > Are there any clear guidelines what feature set form C++11 is safe to
> use?
> > Or we shouldn't limit ourselves until someone starts screaming out laud?
>
> I think the LLVM dev list had some guidelines on this in the last 2 or 3
> months as they moved to a C++11 required stance.  That might be worth
> having a look at.
>
>
Thank you, I'll look for it.



> On Mon, Mar 24, 2014 at 11:36 AM, Piotr Rak <piotr.rak at gmail.com> wrote:
>
>> Hi,
>>
>> 2014-03-24 17:58 GMT+01:00 Greg Clayton <gclayton at apple.com>:
>>
>> Note that std::once can be used to enforce "run once" and we don't have
>>> to worry about each platform (like we would have to if we used
>>> pthread_once).
>>>
>>> Modified version submitted with:
>>>
>>> Author: gclayton
>>> Date: Mon Mar 24 11:50:33 2014
>>> New Revision: 204622
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=204622&view=rev
>>> Log:
>>> Modified patch from Piotr Rak that makes GetSharedModuleList() more
>>> thread safe and also fixed a missed member initialization on the copy
>>> contractor and also makes the assignment operator safer.
>>>
>>> Modified:
>>>    lldb/trunk/source/Core/ModuleList.cpp
>>>
>>>
>>
>> Thanks, that's great we can use that, I have not seen any use of
>> std::once, and that's why I was avoiding it.
>> Like I avoided ranged version of for before I have noticed we already use
>> it.
>> I've seen comments about lack of atomic for Windows in debug shared_ptr
>> implementation, and also we wrap things like mutex, condition variable,
>> etc...
>>
>> For future:
>> Are there any clear guidelines what feature set form C++11 is safe to use?
>> Or we shouldn't limit ourselves until someone starts screaming out laud?
>>
>> Cheers,
>> /Piotr
>>
>>
>> _______________________________________________
>> lldb-dev mailing list
>> lldb-dev at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
>>
>>
>
>
> --
> Todd Fiala | Software Engineer |  tfiala at google.com |  650-943-3180
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20140324/e54d137e/attachment.html>