[lldb-dev] [patch] Change a few struct members from unsigned to signed

Abid, Hafiz Hafiz_Abid at mentor.com
Thu Mar 13 03:52:19 PDT 2014


I did not see hear any complain about this patch from Deepak. So I think it is OK on MSVC.
I will apply it now.

Thanks,
Abid

> -----Original Message-----
> From: Greg Clayton [mailto:gclayton at apple.com]
> Sent: 11 March 2014 17:01
> To: Abid, Hafiz
> Cc: lldb-dev at cs.uiuc.edu; Deepak Panickal <deepak2427 at gmail.com>
> (deepak2427 at gmail.com)
> Subject: Re: [lldb-dev] [patch] Change a few struct members from unsigned
> to signed
> 
> Looks ok as long as people that use MSVC agree it works fine.
> 
> On Mar 11, 2014, at 5:07 AM, Abid, Hafiz <Hafiz_Abid at mentor.com> wrote:
> 
> > Hi,
> > This patches changes the type of 2 struct members from unsigned to
> signed. They are used respectively in InterlockedIncrement and in
> InterlockedExchange respectively which seem to take a signed argument.
> > http://msdn.microsoft.com/en-
> us/library/windows/desktop/ms683614%28v=v
> > s.85%29.aspx
> > http://msdn.microsoft.com/en-
> us/library/windows/desktop/ms683590%28v=v
> > s.85%29.aspx
> >
> > Deepak,
> > Please let me know if it causes any problem with MSVC++.
> >
> > Thanks,
> > Abid
> >
> >
> >
> <signed_type.patch>_______________________________________________
> > lldb-dev mailing list
> > lldb-dev at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev





More information about the lldb-dev mailing list