[lldb-dev] LLDB test executable architectures

[Greg Clayton]

Yes I just run:

cd lldb/test
./dotest.py

And by default I would hope that "detest.py" would be able to be run (as well as dosep.py) on its own with no arguments and it should do the right thing for the currently built lldb.


> On Jul 30, 2014, at 9:43 PM, Zachary Turner <zturner at google.com> wrote:
> 
> Well I guess it would be helpful to know how you run the tests.  Do you run dotest.py from the command line?  Or do you have a tool that drives the script?  Because if it's the latter, then the tool can just pass in whatever architectures it wants.  I have a patch to the CMake build right now that makes the CMake build always pass in the target architectures.  So that will remove the need for this logic for anyone running tests via CMake.  But I'm not sure what you do on Mac.
> 
> I guess what I'm saying is that complicated logic is fine if it's useful.  I just don't know if it's useful (maybe it is, but I don't know what the workflow is like on Mac).  If you guys are already running all the tests via a tool that passes in --arch on the command line, or if you're willing to change whatever tool you do use (the Xcode project?) to pass in --arch, then the logic here probably isn't that useful.
> 
> 
> On Wed, Jul 30, 2014 at 6:58 PM, Greg Clayton <gclayton at apple.com> wrote:
> If the logic is broken, please fix, but don't remove or simplify it just because it is complex. Make sure that if a platform (like darwin) supports both x86_64 and i386 binaries, that the tests run for both so we cover all bases and know if something fails for 32 or 64 bit. Sounds like on Windows you only want to run x86_64 for 64 bit machines or i386 for 32 bit machine right?
> 
> Just make sure Darwin runs both with what ever fix you make.
> 
> > On Jul 29, 2014, at 4:22 PM, Zachary Turner <zturner at google.com> wrote:
> >
> > Currently dotest.py contains the following logic to determine what architectures to compile the test executables as:
> >
> >     if args.archs:
> >         # architectures were specified on the command line, just use them
> >     else:
> >         if (platform_system == 'Darwin' or (platform_system == 'Linux' and compilers == ['clang'])) and platform_machine == 'x86_64':
> >             archs = ['x86_64', 'i386']
> >         else:
> >             archs = [platform_machine]
> >
> > Does anyone actually need this kind of complicated logic?  It's kind of magical and hand-wavy.  There's no indication of why it makes sense that Darwin+x64 system would default to running both x64 and x86 tests, or why linux gcc x64 would run only x64 tests but not x86 tests, even though linux clang x64 would run both sets of tests.
> >
> > I'd like to simplify it if possible (partly because this logic is actually broken on Windows, so I need to revisit it anyway).  Is there any reason we can't just keep it as simple as "If it's on the command line, use it, otherwise default to running only the tests corresponding to the system platform?"
> > _______________________________________________
> > lldb-dev mailing list
> > lldb-dev at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
> 
>